fix typo in slow_fba, and a bug in fast_fba (#99)

* Fix: typo in slow_fba, a bug in fast_fba * remove redundant loop in fast_fba
GeomScale · May 23, 2024 · f24e57c · f24e57c
1 parent 31a8ff8
commit f24e57c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/dingo/fba.py b/dingo/fba.py
@@ -13,7 +13,7 @@
 def slow_fba(lb, ub, S, c):
     """A Python function to perform fba using scipy.optimize LP solver `linprog`
     Returns an optimal solution and its value for the following linear program:
-    min c*v, subject to,
+    max c*v, subject to,
     Sv = 0, lb <= v <= ub
 
     Keyword arguments:

diff --git a/dingo/gurobi_based_implementations.py b/dingo/gurobi_based_implementations.py
@@ -107,9 +107,7 @@ def fast_fba(lb, ub, S, c):
                 if status == GRB.OPTIMAL:
                     optimum_value = -model.getObjective().getValue()
                     v = model.getVars()
-
-                for i in range(n):
-                    optimum_sol.append(v[i].x)
+                    optimum_sol = model.getAttr("X", v)
 
                 optimum_sol = np.asarray(optimum_sol)