Exposed two HMC walks with exponential and Gaussian sampling from Volesti #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vissarion
requested changes
Jul 12, 2023
|
Thanks for this PR! I have a couple of comments. |
|
Could you please also add a couple of tests just to cover those new two walks and show that they work as expected. |
… walks in bindings. Added tests to check they work as expected
TolisChal
reviewed
Jul 24, 2023
TolisChal
reviewed
Jul 24, 2023
TolisChal
reviewed
Jul 31, 2023
…thub actions associated to the mean
…e mean. Now it checks if the size of the matrix steady_states is correct
TolisChal
approved these changes
Aug 9, 2023
TolisChal
reviewed
Aug 9, 2023
TolisChal
reviewed
Aug 9, 2023
TolisChal
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed two Hamiltonian Monte Carlo exact walks with exponential and Gaussian sampling from the random walks on Volesti, changing bindings.cpp and volestipy.pyx to access those walks.