-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile is added to the codebase #79
base: develop
Are you sure you want to change the base?
Conversation
The dockerfile is added which use the Gurobi docker image
@ai-naymul thanks for this PR. I think it is better if we add that file inside @hariszaf what do you think? @ai-naymul ideally a github action could be added to test that the dockerfile works as expected. |
Yeah we should add that instructions stuff after the installation section in the README file... |
@vissarion should I work on the readme file instruction part of these PR right now and make a commit in the same pr or make another PR regarding that? |
I think it is better to do it in this PR. Do you confirm that the docker file you wrote works? What are the commands such that we can reproduce that? Are you able to build dingo in that container and run the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this Dockerfile and its current version fails.
Maybe if you follow the steps described inline, it might work.
dockerfile
Outdated
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# Install dingo | ||
RUN pip install dingo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Dockerfile fails in this line.
This is because dingo
is not on PyPi.
So, maybe, you could follow the installation instructions?
For example,
- get dependencies
apt-get install libsuitesparse-dev &> /dev/null
pip install sparseqr
pip install Cython
pip install cobra
pip install kaleido
- clone
dingo
repo
git clone https://github.com/GeomScale/dingo.git
cd dingo/
git submodule update --init
- get
boost
library:
wget -O boost_1_76_0.tar.bz2 https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.bz2
tar xjf boost_1_76_0.tar.bz2 &> /dev/null
rm boost_1_76_0.tar.bz2 &> /dev/null
- Install
dingo
python setup.py install --user
I think this might work.
first clone the dingo
repo on the image, then run the init submodule
command, get and then follow
Hi @vissarion and @ai-naymul here you may find a working Dockerfile. as I do not know if that's in a best-practices way, please have a look and share thoughts. 🌮 |
Okay I will make the changes |
Oh..I didn't notice that the gurobi is not in pypi library , I am sorry I will fix this asap |
Due to unavailability the docker file is failed to run before now that sloved and instruction for using the dockerfile is added
@hariszaf @vissarion could you please check the recent commit...!! |
The dockerfile is added which use the Gurobi docker image
Fixes #78