Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding test #92

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

vissarion
Copy link
Member

@vissarion vissarion commented Mar 28, 2024

Fixes #72 partly

@@ -83,18 +42,25 @@ def test_rounding_john_position(self):
A_rounded, b_rounded, method = 'billiard_walk', n=1000, burn_in=10, thinning=1
)

temp = np.full((samples.shape[0], samples.shape[1]), Tr_shift)
Tr_samples = Tr.dot(samples.T) + temp.T
Tr_shift = Tr_shift.reshape(Tr_shift.shape[0], 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix, the rest are refactoring

Copy link
Collaborator

@hariszaf hariszaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@TolisChal
Copy link
Member

Thanks @vissarion! Approved.

@vissarion vissarion merged commit c51f0a5 into GeomScale:develop Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rounding.py is excluded from github actions
4 participants