-
Notifications
You must be signed in to change notification settings - Fork 18
passed tests for assignment04 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sskadamb
wants to merge
4
commits into
Geospatial-Python:master
Choose a base branch
from
sskadamb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,9 @@ def read_geojson(input_file): | |
""" | ||
# Please use the python json module (imported above) | ||
# to solve this one. | ||
gj = None | ||
with open(input_file,'r') as file: | ||
gj = json.load(file) | ||
print(gj) | ||
return gj | ||
|
||
|
||
|
@@ -56,25 +58,35 @@ def find_largest_city(gj): | |
population : int | ||
The population of the largest city | ||
""" | ||
city = None | ||
#features is a list, so iteration is by position | ||
#if you want to iterate over the features you need to first grab the list out of the dictionary. | ||
|
||
featureList = gj['features'] | ||
# now that you have the features, compare the pop_max fields to find the largest one | ||
max_population = 0 | ||
for featureEntry in featureList: | ||
if featureEntry["properties"]["pop_max"] > max_population: | ||
max_population = featureEntry["properties"]["pop_max"] | ||
city = featureEntry["properties"]["nameascii"] | ||
|
||
|
||
return city, max_population | ||
|
||
|
||
def write_your_own(gj): | ||
""" | ||
Here you will write your own code to find | ||
some attribute in the supplied geojson file. | ||
|
||
Take a look at the attributes available and pick | ||
something interesting that you might like to find | ||
or summarize. This is totally up to you. | ||
|
||
Do not forget to write the accompanying test in | ||
tests.py! | ||
This function finds the least populated city, pop_min | ||
""" | ||
return | ||
featureList = gj["features"] | ||
minPop = 999999999 | ||
for featureEntry in featureList: | ||
#feature["properties"]["pop_min"] for feature in self.gj["features"] | ||
if featureEntry["properties"]["pop_min"] < minPop: | ||
minPop = featureEntry["properties"]["pop_min"] | ||
city = featureEntry["properties"]["nameascii"] | ||
# minn = min(featureEntry["properties"]["pop_min"]) | ||
# print(minn) | ||
return city, minPop | ||
|
||
def mean_center(points): | ||
""" | ||
|
@@ -93,10 +105,20 @@ def mean_center(points): | |
y : float | ||
Mean y coordinate | ||
""" | ||
x = None | ||
y = None | ||
|
||
return x, y | ||
#find the average of all the X points in the list | ||
|
||
# x_sum = sum(points[0]) | ||
#points_length = len(points) | ||
|
||
sums = map(sum,zip(*points)) # returns iterable object of type map | ||
sumsL = list(sums) | ||
avgs = map(lambda xy: xy/len(points),sumsL) | ||
avgsL = list(avgs) | ||
x = avgsL[0] | ||
y = avgsL[1] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of map, zip, and lambda |
||
return x,y | ||
|
||
|
||
def average_nearest_neighbor_distance(points): | ||
|
@@ -119,8 +141,27 @@ def average_nearest_neighbor_distance(points): | |
Measure of Spatial Relationships in Populations. Ecology. 35(4) | ||
p. 445-453. | ||
""" | ||
mean_d = 0 | ||
|
||
#d_i is the set of all of the distances between i and it's closest neighbor. | ||
#then, between all of those distances, you divide by the number of points. | ||
|
||
#find the distance between a point i and every other point | ||
shDistL =[] #list of shortest distances | ||
for point in points: | ||
shortestDistance = 9999999999 | ||
for dpoint in points: | ||
if point != dpoint: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check out |
||
dist = euclidean_distance(point, dpoint) | ||
if(shortestDistance > dist): | ||
shortestDistance = dist | ||
#now add the shortest distance of that point before it moves on to a new point | ||
shDistL.append(shortestDistance) | ||
|
||
#once shDistL has all of the shortest distances, find the sum of those and divide by the number of points sums = map(sum,zip(*points)) | ||
#sums = map(sum,shDistL) #list like [x] | ||
# print(type(sums)) | ||
sums = sum(shDistL) | ||
mean_d = sums/len(shDistL) | ||
return mean_d | ||
|
||
|
||
|
@@ -138,8 +179,22 @@ def minimum_bounding_rectangle(points): | |
: list | ||
Corners of the MBR in the form [xmin, ymin, xmax, ymax] | ||
""" | ||
|
||
mbr = [0,0,0,0] | ||
# a minimum bounding rectangle would be on the extremes of x/y | ||
|
||
xmin = 99999999999 | ||
ymin = 99999999999 | ||
xmax = -9999999999 | ||
ymax = -9999999999 | ||
for point in points: | ||
if point[0] < xmin: | ||
xmin = point[0] | ||
if point[1] < ymin: | ||
ymin = point[1] | ||
if point[0] > xmax: | ||
xmax = point[0] | ||
if point[1] > ymax: | ||
ymax = point[1] | ||
mbr = [xmin,ymin,xmax,ymax] | ||
|
||
return mbr | ||
|
||
|
@@ -148,7 +203,9 @@ def mbr_area(mbr): | |
""" | ||
Compute the area of a minimum bounding rectangle | ||
""" | ||
area = 0 | ||
length = mbr[2] - mbr[0] | ||
width = mbr[3] - mbr[1] | ||
area = length*width | ||
|
||
return area | ||
|
||
|
@@ -173,7 +230,7 @@ def expected_distance(area, n): | |
The number of points | ||
""" | ||
|
||
expected = 0 | ||
expected = 0.5 * (math.sqrt(area/n)) | ||
return expected | ||
|
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
math.inf
for a really big number?