Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struggle #7

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions point_pattern.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ def read_geojson(input_file):
"""
# Please use the python json module (imported above)
# to solve this one.
gj = None
return gj
with open(input_file, 'r') as f:
gj = json.load(f)
return gj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump this return so that is is indented under the def and resubmit. Should be good to go then.

print(gj)


def find_largest_city(gj):
Expand All @@ -56,10 +58,17 @@ def find_largest_city(gj):
population : int
The population of the largest city
"""
city = None
max_population = 0
city = None
max_population = 0
temp = 0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic looks good. I suspect the issue has to do with reading the geojson file correctly.

return city, max_population
for i in gj:
if i['pop_max'] < temp:
temp = i['pop_max']
city = i['city']
max_population = temp

return city, max_population


def write_your_own(gj):
Expand Down Expand Up @@ -95,6 +104,12 @@ def mean_center(points):
"""
x = None
y = None
for point in points:
x += point[0]
y += point[1]

x = x/len(points)
y = y/len(points)

return x, y

Expand All @@ -119,7 +134,9 @@ def average_nearest_neighbor_distance(points):
Measure of Spatial Relationships in Populations. Ecology. 35(4)
p. 445-453.
"""

mean_d = 0


return mean_d

Expand All @@ -140,6 +157,7 @@ def minimum_bounding_rectangle(points):
"""

mbr = [0,0,0,0]


return mbr

Expand Down