-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Struggle #7
Open
HerczegAdam
wants to merge
12
commits into
Geospatial-Python:master
Choose a base branch
from
HerczegAdam:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Struggle #7
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
26b47c0
First
HerczegAdam 621e0d5
Second
HerczegAdam e45ad32
Third
HerczegAdam ca768d5
Fourth
HerczegAdam ee4a575
Fifth
HerczegAdam 23eb580
Do Over
HerczegAdam 4f48e7f
Do Over 1
HerczegAdam ae7c7bc
Do Over 2
HerczegAdam 92eb5bf
Do Over 3
HerczegAdam 7c2e249
Do Over4
HerczegAdam 4b2876f
Do Over4
HerczegAdam c0ce56f
Again
HerczegAdam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,10 @@ def read_geojson(input_file): | |
""" | ||
# Please use the python json module (imported above) | ||
# to solve this one. | ||
gj = None | ||
return gj | ||
with open(input_file, 'r') as f: | ||
gj = json.load(f) | ||
return gj | ||
print(gj) | ||
|
||
|
||
def find_largest_city(gj): | ||
|
@@ -56,10 +58,17 @@ def find_largest_city(gj): | |
population : int | ||
The population of the largest city | ||
""" | ||
city = None | ||
max_population = 0 | ||
city = None | ||
max_population = 0 | ||
temp = 0 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This logic looks good. I suspect the issue has to do with reading the geojson file correctly. |
||
return city, max_population | ||
for i in gj: | ||
if i['pop_max'] < temp: | ||
temp = i['pop_max'] | ||
city = i['city'] | ||
max_population = temp | ||
|
||
return city, max_population | ||
|
||
|
||
def write_your_own(gj): | ||
|
@@ -95,6 +104,12 @@ def mean_center(points): | |
""" | ||
x = None | ||
y = None | ||
for point in points: | ||
x += point[0] | ||
y += point[1] | ||
|
||
x = x/len(points) | ||
y = y/len(points) | ||
|
||
return x, y | ||
|
||
|
@@ -119,7 +134,9 @@ def average_nearest_neighbor_distance(points): | |
Measure of Spatial Relationships in Populations. Ecology. 35(4) | ||
p. 445-453. | ||
""" | ||
|
||
mean_d = 0 | ||
|
||
|
||
return mean_d | ||
|
||
|
@@ -140,6 +157,7 @@ def minimum_bounding_rectangle(points): | |
""" | ||
|
||
mbr = [0,0,0,0] | ||
|
||
|
||
return mbr | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump this return so that is is indented under the
def
and resubmit. Should be good to go then.