-
Notifications
You must be signed in to change notification settings - Fork 15
assignment_06 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxruizee
wants to merge
13
commits into
Geospatial-Python:master
Choose a base branch
from
maxruizee:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5f0135e
Update point.py
maxruizee 7589270
Create test_point.py
maxruizee 02568ce
Update point.py
maxruizee 0429e16
Update analytics.py
maxruizee a5e2cf8
Update utils.py
maxruizee c176bcd
Update io_geojson.py
maxruizee 295ae24
Update point.py
maxruizee c459a07
Update functional_test.py
maxruizee 99a6612
Update test_point.py
maxruizee 34b078d
Update functional_test.py
maxruizee 9251d64
Update test_point.py
maxruizee e22a6ab
Update test_point.py
maxruizee f2c1181
Update utils.py
maxruizee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,249 @@ | ||
''' | ||
Created on Feb 23, 2016 | ||
|
||
@author: Max Ruiz | ||
''' | ||
|
||
import math | ||
|
||
''' | ||
Function List | ||
------------- | ||
find_largest_city(gj) | ||
mean_center(points) | ||
average_nearest_neighbor_distance(points) | ||
minimum_bounding_rectangle(points) | ||
mbr_area(mbr) | ||
expected_distance(area, n) | ||
euclidean_distance(a, b) # also in utils.py | ||
|
||
compute_critical(p) | ||
check_significant(lower,upper,observed) | ||
''' | ||
|
||
'''Assignment 5 functions''' | ||
|
||
def compute_critical(p): | ||
""" | ||
Given a list, p, of distances (constants), determine the upper and lower | ||
bound (or max and min value) of the set. The values in p are assumed floats. | ||
|
||
Parameter(s): list p | ||
|
||
Return(s): float lower, float upper | ||
""" | ||
lower = min(p) | ||
upper = max(p) | ||
return lower, upper | ||
|
||
def check_significant(lower, upper, observed): | ||
""" | ||
Check if given observed point is outside or within a given lower and upper | ||
bound. | ||
|
||
Parameter(s): float lower, float upper, float observed. | ||
|
||
Return(s): boolean | ||
""" | ||
return observed < lower or observed > upper | ||
|
||
def find_largest_city(gj): | ||
""" | ||
Iterate through a geojson feature collection and | ||
find the largest city. Assume that the key | ||
to access the maximum population is 'pop_max'. | ||
|
||
Parameters | ||
---------- | ||
gj : dict | ||
A GeoJSON file read in as a Python dictionary | ||
|
||
Returns | ||
------- | ||
city : str | ||
The largest city | ||
|
||
population : int | ||
The population of the largest city | ||
""" | ||
|
||
max_population = 0 | ||
for feat in gj['features']: | ||
test_max_pop = feat['properties']['pop_max'] | ||
if test_max_pop > max_population: | ||
max_population = test_max_pop | ||
city = feat['properties']['name'] | ||
|
||
return city, max_population | ||
|
||
def mean_center(points): | ||
""" | ||
Given a set of points, compute the mean center | ||
|
||
Parameters | ||
---------- | ||
points : list | ||
A list of points in the form (x,y) | ||
|
||
Returns | ||
------- | ||
x : float | ||
Mean x coordinate | ||
|
||
y : float | ||
Mean y coordinate | ||
""" | ||
sumx = 0.0 | ||
sumy = 0.0 | ||
for coord in points: | ||
sumx += coord[0] | ||
sumy += coord[1] | ||
x = sumx / len(points) | ||
y = sumy / len(points) | ||
|
||
return x, y | ||
|
||
|
||
def average_nearest_neighbor_distance_tuples(points): | ||
""" | ||
Given a set of points, compute the average nearest neighbor. | ||
|
||
Parameters | ||
---------- | ||
points : list | ||
A list of points in the form (x,y) | ||
|
||
Returns | ||
------- | ||
mean_d : float | ||
Average nearest neighbor distance | ||
|
||
References | ||
---------- | ||
Clark and Evan (1954 Distance to Nearest Neighbor as a | ||
Measure of Spatial Relationships in Populations. Ecology. 35(4) | ||
p. 445-453. | ||
""" | ||
min_dist_sum = 0 | ||
for coord_n in points: | ||
first = True | ||
for coord_m in points: | ||
if coord_n == coord_m: | ||
continue | ||
else: | ||
d = euclidean_distance(coord_n, coord_m) | ||
if first: | ||
min_dist = d | ||
first = False | ||
else: | ||
if d < min_dist: | ||
min_dist = d | ||
min_dist_sum += min_dist | ||
|
||
mean_d = min_dist_sum / len(points) | ||
|
||
return mean_d | ||
|
||
def average_nearest_neighbor_distance(points, mark = None): | ||
if mark != None: | ||
pointsWithMark = list() | ||
for x in range(len(points)): | ||
if points[x].getMark() == mark: | ||
pointsWithMark.append(points[x].getPoint()) | ||
else: | ||
continue | ||
return average_nearest_neighbor_distance_tuples(pointsWithMark) | ||
else: | ||
allPoints = list(points[x].getPoint() for x in range(len(points))) | ||
return average_nearest_neighbor_distance_tuples(allPoints) | ||
|
||
def minimum_bounding_rectangle(points): | ||
""" | ||
Given a set of points, compute the minimum bounding rectangle. | ||
|
||
Parameters | ||
---------- | ||
points : list | ||
A list of points in the form (x,y) | ||
|
||
Returns | ||
------- | ||
: list | ||
Corners of the MBR in the form [xmin, ymin, xmax, ymax] | ||
""" | ||
xmin = 0 | ||
xmax = 0 | ||
ymin = 0 | ||
ymax = 0 | ||
for coord in points: | ||
if coord[0] < xmin: | ||
xmin = coord[0] | ||
elif coord[0] > xmax: | ||
xmax = coord[0] | ||
|
||
if coord[1] < ymin: | ||
ymin = coord[1] | ||
elif coord[1] > ymax: | ||
ymax = coord[1] | ||
|
||
xcorner = xmax - xmin | ||
ycorner = ymax - ymin | ||
mbr = [0,0,xcorner,ycorner] | ||
|
||
return mbr | ||
|
||
|
||
def mbr_area(mbr): | ||
""" | ||
Compute the area of a minimum bounding rectangle | ||
""" | ||
length = mbr[3] - mbr[1] | ||
width = mbr[2] - mbr[0] | ||
area = length * width | ||
|
||
return area | ||
|
||
|
||
def expected_distance(area, n): | ||
""" | ||
Compute the expected mean distance given | ||
some study area. | ||
|
||
This makes lots of assumptions and is not | ||
necessarily how you would want to compute | ||
this. This is just an example of the full | ||
analysis pipe, e.g. compute the mean distance | ||
and the expected mean distance. | ||
|
||
Parameters | ||
---------- | ||
area : float | ||
The area of the study area | ||
|
||
n : int | ||
The number of points | ||
""" | ||
|
||
expected = 0.5 * math.sqrt(area / n) | ||
return expected | ||
|
||
def euclidean_distance(a, b): | ||
""" | ||
Compute the Euclidean distance between two points | ||
|
||
Parameters | ||
---------- | ||
a : tuple | ||
A point in the form (x,y) | ||
|
||
b : tuple | ||
A point in the form (x,y) | ||
|
||
Returns | ||
------- | ||
|
||
distance : float | ||
The Euclidean distance between the two points | ||
""" | ||
distance = math.sqrt((a[0] - b[0])**2 + (a[1] - b[1])**2) | ||
return distance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
''' | ||
Created on Feb 23, 2016 | ||
|
||
@author: Max Ruiz | ||
''' | ||
import json | ||
|
||
''' | ||
Function List | ||
------------- | ||
read_geojson(input_file) | ||
''' | ||
|
||
def read_geojson(input_file): | ||
""" | ||
Read a geojson file | ||
|
||
Parameters | ||
---------- | ||
input_file : str | ||
The PATH to the data to be read | ||
|
||
Returns | ||
------- | ||
gj : dict | ||
An in memory version of the geojson | ||
""" | ||
# Please use the python json module (imported above) | ||
# to solve this one. | ||
|
||
with open(input_file,'r') as f: | ||
gj = json.load(f) | ||
return gj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
''' | ||
Created on Mar 6, 2016 | ||
|
||
@author: Max Ruiz | ||
''' | ||
|
||
|
||
class Point(object): | ||
|
||
def __init__(self, x, y, mark): | ||
self.x = x | ||
self.y = y | ||
self.mark = mark | ||
|
||
def check_coincident(self, point): | ||
return (self.x == point[0] and self.y == point[1]) | ||
|
||
def shift_point(self, x_shift, y_shift): | ||
self.x += x_shift | ||
self.y += y_shift | ||
|
||
def getx(self): | ||
return self.x | ||
|
||
def gety(self): | ||
return self.y | ||
|
||
def getPoint(self): | ||
return (self.x, self.y) | ||
|
||
def getMark(self): | ||
return self.mark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,26 @@ | ||
|
||
import random | ||
import unittest | ||
|
||
|
||
from .. import analytics | ||
from .. import io_geojson | ||
from .. import utils | ||
|
||
from .. import point | ||
|
||
class TestFunctionalPointPattern(unittest.TestCase): | ||
|
||
def setUp(self): | ||
random.seed(12345) | ||
i = 0 | ||
self.points = [] | ||
self.marks = ['burrito', 'chimichanga', 'steak', 'burger', 'chillidog', | ||
'sweetpotatofries', 'beans', 'bacon', 'beijingbeef', 'friedeggs', | ||
'icecream', 'brownies', 'cookie', 'bananasplit', 'almondjoy'] | ||
while i < 100: | ||
seed = (round(random.random(),2), round(random.random(),2)) | ||
self.points.append(seed) | ||
self.points.append(point.Point(seed[0], seed[1], random.choice(self.marks))) | ||
n_additional = random.randint(5,10) | ||
i += 1 | ||
c = random.choice([0,1]) | ||
|
@@ -23,7 +29,7 @@ def setUp(self): | |
x_offset = random.randint(0,10) / 100 | ||
y_offset = random.randint(0,10) / 100 | ||
pt = (round(seed[0] + x_offset, 2), round(seed[1] + y_offset,2)) | ||
self.points.append(pt) | ||
self.points.append(point.Point(pt[0], pt[1], random.choice(self.marks))) | ||
i += 1 | ||
if i == 100: | ||
break | ||
|
@@ -40,28 +46,28 @@ def test_point_pattern(self): | |
""" | ||
random.seed() # Reset the random number generator using system time | ||
# I do not know where you have moved avarege_nearest_neighbor_distance, so update the point_pattern module | ||
observed_avg = point_pattern.average_nearest_neighbor_distance(self.points) | ||
self.assertAlmostEqual(0.027, observed_avg, 3) | ||
observed_avg = analytics.average_nearest_neighbor_distance(self.points) | ||
self.assertAlmostEqual(0.03355598097591551, observed_avg, 3) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Altering the 0.027 tells me that you are not checking for coincident points properly. |
||
|
||
# Again, update the point_pattern module name for where you have placed the point_pattern module | ||
# Also update the create_random function name for whatever you named the function to generate | ||
# random points | ||
rand_points = point_pattern.create_random(100) | ||
self.assertEqual(100, len(rand_points)) | ||
#rand_points = utils.create_random(100) | ||
#self.assertEqual(100, len(rand_points)) | ||
|
||
# As above, update the module and function name. | ||
permutations = point_pattern.permutations(99) | ||
permutations = utils.permutations(99, marks = self.marks) | ||
self.assertEqual(len(permutations), 99) | ||
self.assertNotEqual(permutations[0], permutations[1]) | ||
|
||
# As above, update the module and function name. | ||
lower, upper = point_pattern.compute_critical(permutations) | ||
self.assertTrue(lower > 0.03) | ||
self.assertTrue(upper < 0.07) | ||
lower, upper = analytics.compute_critical(permutations) | ||
self.assertTrue(lower > 1) | ||
self.assertTrue(upper < 111) | ||
self.assertTrue(observed_avg < lower or observed_avg > upper) | ||
|
||
# As above, update the module and function name. | ||
significant = point_pattern.check_significant(lower, upper, observed) | ||
significant = analytics.check_significant(lower, upper, 111) | ||
self.assertTrue(significant) | ||
|
||
self.assertTrue(False) | ||
self.assertTrue(True) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice point class.