assignment_08 submission #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice job fighting with the CI configuration file. I have a note in for next semester to set this up for you. I can only imagine that youj are feeling very comfortable with how to set up a CI environment now. |
| utils.create_random(n), | ||
| mark | ||
| ) | ||
| ) |
There was a problem hiding this comment.
As a style things, the floating parentheses are viewed as not Pythonic by the larger Python community. Not a big deal, but something that you might get a code comment on if you are doing Python work in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used an iPython notebook for Deliverable 4. Moved source code into src/ folder so that the notebook could be in the root directory.