Latest SpartanLync Integration contributions to real-time-map codebase v2.0

[spartanlync]

A fork was created using our SpartanLync Github account which we will dedicate to improvements and fixes felt to add value to Geotab customers and other 3rd-party Integrators / Resellers developers using the base Real-Time-Map.

• Added Vehicle Name to Map markers - Helps customers identify which vehicle to click on a crowded map

• Replaced JS alerts() with UI-compliant showSnackBar() notifications

• User usability improvement: Vehicles Tab as default in ConfigView panel. Will feel vehicles Tab will get far more usage from customers than the Exceptions Tab, so why not make that screen the default when the ConfigView panel is opened.

• Moved Standalone Logout button to top-left screen on map, so it no longer obstructs the ConfigView Panel

• Added the 'server' login property to the userInfo object and added the MyGeotab state property to apiConfig object so integrations can use Geotab Page State Methods and backend API access validations

• CopyWebpackPlugin Vulnerability Upgrade fix - resolves dev build from breaking after vulnerability upgrade

[JZ6]

Thanks for your mr! Could you take a look at the conflicts and resolve them? Thanks!

[spartanlync]

Hey Jay,

HOW? The changes from spartanlync:master are correct choice
But I can't do it because I don't have write access to Geotab/real-time-map

In the Github UI I can only view the conflict diffs.
I don't see any controls for me to actually choose how to resolve the conflicts.

I think that is what you do as the maintainer of Geotab/real-time-map.
I believe you simply choose my version from spartanlync:master

[JZ6]

@smnaqvi

[smnaqvi]

Hi @spartanlync ,
thank you for the PR, please review the formatting settings on your branch. Most changes seem to be due to formatting.

[spartanlync]

@smnaqvi - Hi, Maybe you can clarify what formatting was causing issues that I should look for in my settings?

What I can guarantee is that every file in the PR had changes absolutely required to accomplish the mentioned functional improvements. So I apologize for mu editor settings, but please ignore the formatting and focus on what is important to implementing the additional features or fixes.

[smnaqvi]

@spartanlync , I have gone through the changes and they're all good. However in order for this branch to be merged into the repo, the formatting has to be consistent. The formatting settings are present in the repo, however it may be much easier to do save without formatting on your changed files if you don't want to change your existing editor settings.

This link has more info about saving without formatting for VS code : https://glebbahmutov.com/blog/configure-prettier-in-vscode/#:~:text=In%20order%20to%20avoid%20reformatting,Formatting%22%20command%20%2D%20use%20that.

Most other editors also have a save without formatting options.

[spartanlync]

@smnaqvi - Awesome good to know. Will read the article and see what can be done to improve the formatting on our next contribution. Regards