CI use all action #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out that he will use the default action with command |
|
should we replace the snippet code by something else (not using pinocchio) or install pinocchio in the CI ? |
|
I think we should replace the snippet by something else. Simple math, event without numpy, would do |
TheoMF
force-pushed
the
fix_#27
branch
2 times, most recently
from
ef6f283
to
3e45bfd
Compare
nim65s
reviewed
Aug 3, 2023
Co-authored-by: Guilhem Saurel <[email protected]>
|
should we re-add the 3 pipx install ruff,black and isort or maybe create a requirement.txt file ? |
|
No, they are already in pyproject.toml. But I had forgotten they were optional. I'll fix this, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27