[#190] display responsible organ on the task page and add a tooltip f… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrie
requested changes
Jun 27, 2023
|
When going through this, I also wonder, if we should do it with a dedicated model and a |
cafischer
force-pushed
the
190-responsible-organ
branch
2 times, most recently
from
db9a4e3
to
10844dc
Compare
|
For now I don't see the value of moving it into another model. What would be the arguments for doing that? |
cafischer
force-pushed
the
190-responsible-organ
branch
2 times, most recently
from
ae605db
to
ad9e12d
Compare
|
With respect to having a separate model, I agree with @cafischer. From my point of view, as long as it does not avoid a lot of extra work in the future, we should never implement anything until one of the pilots/teams actually needs it. |
cafischer
force-pushed
the
190-responsible-organ
branch
from
12be32d
to
150a610
Compare
…ation on mobile devices
cafischer
force-pushed
the
190-responsible-organ
branch
from
150a610
to
7df47cf
Compare
fblampe
approved these changes
Aug 10, 2023
|
@mdrie's comments are now accounted for so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #190