Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly transition to ES6 JavaScript from CoffeeScript #433

Open
3 of 6 tasks
Gert-dev opened this issue Jun 2, 2018 · 1 comment
Open
3 of 6 tasks

Properly transition to ES6 JavaScript from CoffeeScript #433

Gert-dev opened this issue Jun 2, 2018 · 1 comment

Comments

@Gert-dev
Copy link
Owner

Gert-dev commented Jun 2, 2018

Using the decaffeinate project the initial code has been converted to JavaScript (see #375 or 293eb20). This is just the first step however, as there are other things to do:

  • Implement suggestions shown on top of each file
  • Set up ESLint
    • Fix "atom" not being recognized by ESLint
    • Investigate enabling additional rules
    • Fix open issues shown by ESLint
  • Rewrite to use ES6 modules instead of require syntax
@twifty
Copy link

twifty commented Jun 2, 2018

My fix for "atom" not being recognized is a /* global atom */ at the top of the file. I also tend to also specify global itself as a global /* global global atom */, that way I can do thing like global.setTimeout without ESLint complaining. Other items like console.log I do on a per-line basis so as not to leave forgotten debug/dev helpers in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants