Fix ESLint issues, improve classes #528
Conversation
Blah blah blah... :) Convert using static initClass() to constructor() also.
Their base is MultiSelectionView.
|
Looking at commit diffs is better (for reviewers). |
|
Not sure if you were waiting for my review, but these changes look fine to me. Looking back now makes me realize how much the ecosystem has changed (again) since then - the code being refactored now was a conversion from CoffeeScript (remember that? 😄). Not necessary for this MR, but maybe it's a good idea to customize the ESLint ruleset to your liking (if you want), and then let it autofix as much as possible. For the formatting, you could try something like Prettier, as it can also autoformat pretty much everything. |
|
Well, CoffeeScript? A subset of Coffee language? 😁 I'm not really familiar with the JavaScript ecosystem, but I might have to get my hands dirty with it. So thanks for the tip, I would try that. And, good to hear you reviewed it! Thanks! |
Targetting #433.