Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESLint issues, improve classes #528

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Fix ESLint issues, improve classes #528

merged 6 commits into from
Jul 26, 2022

Commits on Jul 18, 2022

  1. Fix max-line ESLint errors (lines exceeding 120 characters)

    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    19c3159 View commit details
    Browse the repository at this point in the history

  2. Use normal JS classes instead of using a variable calling a function 

    Blah blah blah... :) Convert using static initClass() to constructor()
also.
    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    2ba970a View commit details
    Browse the repository at this point in the history

  3. Remove or suppress unused variable errors of ESLint

    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    7bb9c91 View commit details
    Browse the repository at this point in the history

  4. Move common functionality from Refactoring View classes to their base 

    Their base is MultiSelectionView.
    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    a8144c9 View commit details
    Browse the repository at this point in the history

  5. Remove unused comments, other code improvements

    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    7afc023 View commit details
    Browse the repository at this point in the history

  6. Add some missing semicolons and remove unnecessary code

    @machitgarha
    machitgarha committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    d16aecf View commit details
    Browse the repository at this point in the history