Skip to content

Commit

Permalink
fix proto breaking change (#843)
Browse files Browse the repository at this point in the history
  • Loading branch information
thesyncim authored Nov 14, 2024
1 parent 8fdd3f9 commit 707943f
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 40 deletions.
12 changes: 7 additions & 5 deletions generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ PB=$REPO/protobuf

export PATH=/opt/.protoc/bin:$PWD/.protoc/bin:$PATH

REALPATH=${REALPATH:-$(if [[ "$OSTYPE" == "darwin"* ]]; then echo "grealpath"; else echo "realpath"; fi)}
if ! command -v $REALPATH &> /dev/null; then
echo "$REALPATH command not found. Please install it and try again."
exit 1
fi
# In some systems like Mac OS 13.0.1, the realpath defaults to
# the system installed one which does not support flags like
# --relative-path. This results in the scripts erroring out.
# The coreutils installed with Homebrew (as mentioned in README)
# installs GNU realpath which could be available as "grealpath"
# which actually works. Hence, the option to customize REALPATH
REALPATH=${REALPATH:-realpath}

GEN_PROFILE=${1:-go}

Expand Down
9 changes: 2 additions & 7 deletions protobuf/video/sfu/models/models.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion protobuf/video/sfu/models/models.proto
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ message PublishOption {
}

message Codec {
uint32 payload_type = 13;
uint32 payload_type = 16;
string name = 10;
uint32 clock_rate = 14;
string encoding_parameters = 15;
Expand Down
56 changes: 29 additions & 27 deletions protobuf/video/sfu/models/models_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 707943f

Please sign in to comment.