V5: Use JSON encoders and decoders from StreamCore #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
laevandus
commented
Oct 29, 2025
| } else if let stringValue = try? container.decode(String.self, forKey: key) { | ||
| value = stringValue | ||
| } else if let intValue = try? container.decode(Int.self, forKey: key) { | ||
| if let intValue = try? container.decode(Int.self, forKey: key) { |
There was a problem hiding this comment.
StreamCore date parser handles int and double, so the order here becomes important (no type info and we just try types one by one)
laevandus
changed the title
Generated by 🚫 Danger |
Public Interface🚀 No changes affecting the public interface. |
SDK Performance
|
martinmitrevski
approved these changes
Oct 31, 2025
nuno-vieira
approved these changes
Oct 31, 2025
laevandus
added a commit
that referenced
this pull request
Nov 5, 2025
laevandus
added a commit
that referenced
this pull request
Nov 5, 2025
|
SDK Size
|
StreamChat XCSize
Show 248 more objects
|
StreamChatUI XCSize
Show 291 more objects
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Fixes IOS-1206
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepo