Show typing suggestions for text with whitespace #781
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
force-pushed
the
fix/typing-suggestions-with-names
branch
from
22df874 to
4150395
Compare
laevandus
commented
Mar 11, 2025
Comment on lines
-123
to
-125
| guard !suggestionText.contains(" ") else { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Can't figure out why this was added here. Otherwise the implementation is same as in the UIKit.
SDK Size
|
martinmitrevski
approved these changes
Mar 11, 2025
testableapple
approved these changes
Mar 12, 2025
# Conflicts: # CHANGELOG.md
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Link
IOS-700
🎯 Goal
Show typing suggestions for full name
🛠 Implementation
Typing suggestions were explicitly ignoring any whitespace while UIKit SDK does allow it. Otherwise the logic is the same.
🧪 Testing
🎨 Changes
☑️ Checklist