Api v2

[kablamo]

This is going to be a big pr. It is not finished. But I wanted to give you the chance to comment and review as I write it.

[kablamo]

Hi @Getty! This is ready for review/merge. Any feedback is welcome.

I haven't implemented all of the v2 api because its big. I only did ManagedDomains and Records. I plan to add HealthChecks in another pr.

V2 docs: http://www.dnsmadeeasy.com/wp-content/uploads/2014/07/API-Docv2.pdf
V1 docs: http://www.dnsmadeeasy.com/wp-content/themes/appdev/pdf/API-Documentation-DM_20110921.pdf

[kablamo]

You can ignore the travis failures btw. I'm not sure what thats about. There is not even a .travis.yml.

[Getty]

I check into it the next days, i am very busy with work right now :)

[kablamo]

Sure no worries! I understand.

[kablamo]

I can't build this package using your dzil plugin from cpan. Any ideas?

dzil build
[DZ] beginning to build WWW-DNSMadeEasy
[@GETTY/Git::NextVersion] Bumping version from 0.001 to 0.002
[DZ] guessing dist's main_module is lib/WWW/DNSMadeEasy.pm
[@GETTY/@Basic/ExtraTests] rewriting release test xt/release/pod-syntax.t
Duplication of element resources.repository.web at /usr/local/lib/perl5/lib/perl5/Dist/Zilla.pm line 524.

I also tried building your dzil plugin from your github repo but ran into all kinds of problems when I ran 'dzil authordeps | cpanm' -- many modules that would not install. Some of them require the latest version of Module::Load and some require an earlier version.

[Getty]

But you do have all packages required by dzil on latest? I will check that up, might be that its old setup and i have to update, but normally i release very often with those here ;)

[kablamo]

$ cpanm Dist::Zilla
Dist::Zilla is up to date. (5.025)
$ dzil authordeps | cpanm
Dist::Zilla::Plugin::Prereqs is up to date. (5.025)
Dist::Zilla::PluginBundle::GETTY is up to date. (0.008)

For now, I've managed to use Minilla to do a build for internal release. The pod is messed up, but other than that it should be fine I think.

[Getty]

HOLY SHIT, thats REALLY old, i just realize that is not even converted to my REAL bundle @author::GETTY ;-) I am doing this now haha

[Getty]

I also see this Duplication of element resources.repository.web now, its overall, some package must have introduced it, as i made no changes at all. I will hunt it down and come back to you.

[Getty]

Fixed version of my bundle:
https://cpan.metacpan.org/authors/id/G/GE/GETTY/Dist-Zilla-PluginBundle-Author-GETTY-0.105.tar.gz
and the new dist.ini (and other files required) for the new setup are now committed on the master! Have fun :)

[kablamo]

Thanks!

[kablamo]

ping @Getty. Start of the year is probably a busy time too. :)

[Getty]

Yeah sorry, please hold on still, i really have to finish my current mission before i have any head for this.

[kablamo]

@Getty I appreciate you are super busy and this is a giant pull request. I would like to get this on cpan soon though. I am happy to help you out anyway I can. I am happy to be a co maintainer if that helps.

If you don't have a chance to work on it before April, I'll probably post it as a new module under a new namespace. This pull request might make more sense as a new module anyway since version 2 is very different from version 1.

Let me know what you think or how I can help.

[Getty]

Yeah, thats a fair deal, i am in the end turns of my current mission, so its just a matter of days till i can actually breathe.

[Getty]

BTW for starter you should make the travis test working (as in fire up dzil build so that you get travis.yml commit it and assure tests approve!

[kablamo]

Cool. Sounds good. However, it looks like there are some issues with the dzil pluginbundle:

$ pmvers Dist::Zilla
5.025
$ pmvers Dist::Zilla::PluginBundle::Author::GETTY
0.110
$ dzil test
[DZ] building distribution under .build/_lcqq4NQPP for installation
[DZ] beginning to build WWW-DNSMadeEasy
[@Author::GETTY/Git::NextVersion] Bumping version from 0.001 to 0.002
[DZ] guessing dist's main_module is lib/WWW/DNSMadeEasy.pm
[@Author::GETTY/@Filter/ExtraTests] rewriting release test xt/release/pod-syntax.t
[@Author::GETTY/Prereqs::FromCPANfile] Parsing 'cpanfile' to extract prereqs
[DZ] attempt to add Changes multiple times; added by: filename set by Git::GatherDir (Dist::Zilla::Plugin::Git::GatherDir line 91); encoded_content added by @Author::GETTY/Git::GatherDir (Dist::Zilla::Plugin::Git::GatherDir line 92); content added by @Author::GETTY/ChangelogFromGit (Dist::Zilla::Plugin::ChangelogFromGit line 221)
aborting; duplicate files would be produced at local/lib/perl5/Dist/Zilla/App/Command/test.pm line 69.

[Getty]

Just add

no_changelog_from_git = 1

To the dist.ini configuration of [@author::GETTY]

[kablamo]

Strange doesn't look like travis is running. Do you have it turned on here?
https://travis-ci.org/Getty/p5-www-dnsmadeeasy/settings

[Getty]

https://travis-ci.org/Getty/p5-www-dnsmadeeasy/pull_requests

It normally does ;) It is activated i checked to be sure travis didn't fucked up something

[Getty]

https://travis-ci.org/Getty/p5-www-dnsmadeeasy/builds here also

[Getty]

I "readded" Travis now, lets hope that might fix it, dont see else obvious whats wrong (but still a bit unconcentrated)

[kablamo]

I realize it was doing builds in the past but I can't figure out why its not doing them anymore. Are you sure you have 'Build pull requests' on in Travis settings?

https://travis-ci.org/Getty/p5-www-dnsmadeeasy/settings

I'm out of ideas.

[Getty]

Sadly yes :( http://i.imgur.com/3KqPaso.png

P.S.: Test::LoadAllModules is no good, i used that in the past but now i make a loop and make the list by hand. Its not the module itself which is the problem, its the way it is itself made and which modules its using, its often a blocker on installation.

At the weekend i will overview your latest changes and we can bring this out

[kablamo]

ok thanks will revert test changes. Maybe I have to close the pull request and create a new one to get travis working.

[Getty]

Might be an idea

[kablamo]

Not sure whats up with travis not showing up for this pr. But I turned on tests for my fork here:
https://github.com/kablamo/p5-www-dnsmadeeasy/branches

[RickMeasham]

Hi @Getty and @kablamo .. what's the sitrep with this module? The above looks like @kablamo has a working version on the 2.0 interface that includes record updates. The live version points at v1.2 and doesn't allow for record updates.