Preferences system and api #3958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Konicai
commented
Jul 10, 2023
•
Konicai
commented
- actually expose the system to the api
- fix onUpdate
- allow not providing a cumulus Component (don't show in settings form)
- player leave event
- testing
- javadoc
- i'll write more here later when this is more filled in
Camotoy
reviewed
Aug 6, 2023
| @@ -95,4 +98,12 @@ public interface GeyserConnection extends Connection, CommandSource { | |||
| */ | |||
| @NonNull | |||
| Set<String> fogEffects(); | |||
|
|
|||
| <T> void storePreference(@NonNull PreferenceKey<T> key, @NonNull Preference<T> preference); | |||
There was a problem hiding this comment.
Javadocs here please. We should emphasize this system is Geyser and not Bedrock.
Camotoy
reviewed
Aug 6, 2023
|
|
||
| import java.util.Objects; | ||
|
|
||
| public abstract class Preference<T> { |
There was a problem hiding this comment.
after the structure is finalized :p
This was referenced Aug 15, 2023
Open
Konicai
added
the
PR: On hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.