Implemented a way to close forms from floodgate #5247
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas-tle
approved these changes
Dec 29, 2024
onebeastchris
approved these changes
Dec 29, 2024
| @@ -67,6 +69,12 @@ public void translate(GeyserSession session, ClientboundCustomPayloadPacket pack | |||
| session.ensureInEventLoop(() -> { | |||
| byte[] data = packet.getData(); | |||
|
|
|||
| // If the data is empty, we just need to close the form | |||
| if (data.length == 0) { | |||
| session.sendUpstreamPacketImmediately(new ClientboundCloseFormPacket()); | |||
There was a problem hiding this comment.
This can use session#closeForm instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
My PRs are quite small and just aims to add the ability to close forms from the floodgate api.
I made it the simplest possible, it's just sending empty form data to geyser through the form plugin channel and then when geyser receive that empty data it send a form close packet down the connection pipeline.
This PR goes along with this one I made on the floodgate repo.