Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Brand message being sent too early #5265

Merged
merged 7 commits into from
Jan 12, 2025

Conversation

onebeastchris
Copy link
Member

@onebeastchris onebeastchris commented Jan 5, 2025

Further:

Main changes:

  • Moves the Geyser SessionAdapter listener for MCPL into a separate class, and adds it after the default listener to ensure that MCPL's protocol state switching happens before Geyser translates anything
  • Removes the (login) disconnect packet listeners in favor of the DisconnectedEvent - those translators wouldn't be useful as the default mcpl listener already handles them
  • Geyser now changes the disconnect messages in an internal event subscriber, thereby allowing extension etc to see the original reason set by the Java server

@Budderman18
Copy link

Im having this message occur with some bedrock players which results in their brand being null: [Geyser-Spigot] Tried to send ServerboundCustomPayloadPacket packet while not in CONFIGURATION outbound state. Current state: LOGIN

@onebeastchris
Copy link
Member Author

@Budderman18 Thanks; fixed that.

@onebeastchris onebeastchris merged commit 58e2f17 into GeyserMC:master Jan 12, 2025
2 checks passed
@onebeastchris onebeastchris deleted the defaultListener branch January 12, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants