Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create contribution.md #42

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Create contribution.md #42

merged 3 commits into from
Jan 25, 2025

Conversation

PhidLarkson
Copy link
Contributor

Contribution.md, a standalone markdown file with regular updates as to how to set up and what to do in your editor

@PhidLarkson PhidLarkson self-assigned this Nov 1, 2024
complete contribution markdown
@PhidLarkson PhidLarkson marked this pull request as ready for review November 1, 2024 21:32
@PhidLarkson PhidLarkson added the documentation Improvements or additions to documentation label Nov 1, 2024
pip install .
```

3. **Set Up Development Tools (Optional but Recommended):**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit should be covered by the pyproject.toml and automatically install dev-dependencies. Correct? @Lagyamfi .
I think linting and formatting should be mandatory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should a way to install dev-dependencies using poetry @PhidLarkson

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I would be adding black and ruff too

contribution.md Outdated

1. **Create a Branch:**
Create a branch for your work. Use a meaningful name that hints at the purpose (e.g., `feature-enhance-translation`):
```bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to specify here exactly what git commands to use. It would differ based on the contributors workflow whether terminal or gui based. We can describe here what is expected generally and probably not step by step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright well noted, I will sort that out in a bit


2. **Add New Test Cases:**
If your feature or bug fix requires new tests, create them to ensure comprehensive coverage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a step here for running linting

@Lagyamfi Lagyamfi merged commit bd4511c into master Jan 25, 2025
1 check failed
@Lagyamfi Lagyamfi deleted the PhidLarkson-patch-1 branch January 25, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants