-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch murmur container to mumble-voip/mumble-docker #1662
Conversation
Sorry for taking so long to get to this. PR looks good to me, but based on the volume changes I have a question. Will the existing user data be used by the new container? or will users have to shuffle around some of the files in their config folder to have the new container pick them up? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm doubtful that data will transfer over cleanly. |
I do like the idea of switching to this image, but I also wonder if we should just make a new app folder with the name |
If you want to work this image change into your breaking PR I'm fine with that. I'm honestly not sure how we can do this in a way which is least annoying to users of mumble. I was trying to seamlessly swap over the container so it gets recreated without them having to redo their configuration but the data structure is different. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Pull request
Purpose
This is a work in progress that I'm submitting for comments. It should address #1635.
Approach
How does this change address the problem?
This replaces the image while trying to keep the old variables the same so things don't break on upgrade for users.