Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apprise_tag to apprise.labels.yml #1680

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Add apprise_tag to apprise.labels.yml #1680

merged 3 commits into from
Oct 9, 2023

Conversation

idolize
Copy link
Contributor

@idolize idolize commented Oct 9, 2023 •
edited
Loading

Pull request

Purpose
Fix #1679

Approach
How does this change address the problem?

Learning
I saw that other containers had this tag but Apprise did not

Requirements
Check all boxes as they are completed

@idolize idolize requested review from a team as code owners October 9, 2023 21:21
@github-actions github-actions bot added the repo Automatic label label Oct 9, 2023
@idolize idolize mentioned this pull request Oct 9, 2023
Closed
nemchik
nemchik approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! it was missed because it didn't have the restart line either and I used that for pattern matching to add the tag line.

@nemchik nemchik merged commit ecbc1b6 into GhostWriters:master Oct 9, 2023
@idolize idolize deleted the patch-1 branch October 9, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees
No one assigned
Labels
repo Automatic label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Apprise - Error response from daemon: invalid reference format
2 participants
@idolize @nemchik