Add homepage #1693
Merged
Add homepage #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anybody look into it? |
You did not fix the issue I highlighted - it will fail the linter. |
angrycuban13
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
This needs a new line at the end of the file
|
FYI I followed up with #1700 to remove files for unsupported CPU types (DS only supports x86_64 and aarch64), and fix a spelling error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
Added homepage containers.
Approach
Added homepage containers with documents
Open Questions and Pre-Merge TODOs
Check all boxes as they are completed
Learning
https://gethomepage.dev/v0.8.0/installation/docker/
Requirements
Check all boxes as they are completed