Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ds getting false positives for special variables #1783

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

CLHatch
Copy link
Contributor

@CLHatch CLHatch commented Sep 8, 2024

ds was detecting variables such as GLUETUN_ENVIRONMENT_VPN_PORT_FORWARDING as being a GLUETUN_PORT_XXXX variable.

Pull request

Purpose
Describe the problem or feature in addition to a link to the issues.

Approach
How does this change address the problem?

Open Questions and Pre-Merge TODOs
Check all boxes as they are completed

  • Use github checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem

Requirements
Check all boxes as they are completed

`ds` was detecting variables such as `GLUETUN_ENVIRONMENT_VPN_PORT_FORWARDING` as being a `GLUETUN_PORT_XXXX` variable.
@CLHatch CLHatch requested a review from a team as a code owner September 8, 2024 17:47
@github-actions github-actions bot added the core Automatic label label Sep 8, 2024
@CLHatch CLHatch self-assigned this Sep 8, 2024
@CLHatch CLHatch requested review from a team and removed request for a team September 8, 2024 18:51
@nemchik nemchik merged commit b14555a into master Sep 11, 2024
19 checks passed
@nemchik nemchik deleted the CLHatch-patch-1 branch September 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Automatic label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants