Fix bad link handling in Flash hijack (resolves #603)

GiovanH · Aug 24, 2024 · ab45d97 · ab45d97
1 parent 5620e9c
commit ab45d97
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -12,9 +12,9 @@
     }
   ],
   "engines": {
-    "node": ">= 18.20"
+    "node": "18.20"
   },
-  "version": "2.5.2",
+  "version": "2.5.3",
   "license": "GPL-3.0",
   "repository": "github:Bambosh/unofficial-homestuck-collection",
   "private": true,

diff --git a/src/components/UIElements/MediaEmbed.vue b/src/components/UIElements/MediaEmbed.vue
@@ -512,7 +512,7 @@ document.addEventListener('click', function (e) {
           break
         case 'link':
           if (param != 'about:srcdoc') {
-            this.$pushURL(this.$getResourceURL(param), this.$parent.tab.key)
+            this.$pushURL(this.$getResourceURL(param))
           } else {
             this.$logger.warn("Tried to navigate page to srcdoc!")
           }

diff --git a/src/main.js b/src/main.js
@@ -148,7 +148,7 @@ Vue.mixin({
       const urlObject = new URL(url_str)
 
       function _openExternal(to_) {
-        if (!isWebApp) {
+        if (!window.isWebApp) {
           shell.openExternal(to_)
         } else {
           window.open(Resources.resolveURL(to_), '_blank').focus();