Reduced motion options for gifs and flashes #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main.js
Outdated
| assets_root: `http://127.0.0.1:${port}/` | ||
| }) | ||
| const Store = require('electron-store') | ||
| store = new Store() |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
GiovanH
force-pushed
the
giffer
branch
3 times, most recently
from
972fb72
to
18feaf9
Compare
Open
Bambosh
approved these changes
Oct 2, 2023
Bambosh
reviewed
Oct 8, 2023
| @@ -0,0 +1,107 @@ | |||
| <template> | |||
| <div class='media'> | |||
There was a problem hiding this comment.
This extra div means Vue's scoping will break any external CSS that expected the MediaEmbed to be a plain <img>. Can work around it on a case by case basis with ::v-deep, but that's gonna be super easy to forget to test.
Bambosh
requested changes
Oct 8, 2023
Bambosh
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #487