-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wireframes for Home page Added #9
Conversation
1. A separate folder named 'Wireframes' has been added. In it three different mockups of home page are there. 2. Of there will be infinite scroll kind of structure(as observed in the three given links in issue GirlScriptSummerOfCode#2) but on scrolling there will link to other tabs as far as I observed. That's why I have created only the main(home) part. 3. If you want any changes in mock-ups, do comment below I will update them either in this PR or a new one as mentors/admin say. Solves a part of issue GirlScriptSummerOfCode#2
@lalitmee Please review this PR. |
Hey @shreyateeza,
About the Design
But you can wait for the review of other mentors, what they say about the color scheme. 😇 |
@lalitmee Thank you so much for the appreciation! :) |
Hi @shreyateeza, great work!! Few things you can improve on -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design is good @shreyateeza but I think the header is not looking good at the bottom, one more issue that I realized is the that the color combination is not catchy, there are too many bright colors that irritate eyes, I think we should take two background schemes and use them alternatively (like blue and white backgrounds or grey and white).
@amritsrivastava I am working on updating the colour combination. |
I used WP online to design the wireframes. In it, I am having trouble changing the menu items' colour. |
@shreyateeza any updates? |
Wordpress is not getting installed on the desktop. |
I think you can, but, be sure to open a related issue for adjusting the font face/colors. |
@shreyateeza is the problem still not resolved without your wordpress? |
@troublemagnet Unfortunately no, it's still not resolved :( |
@AvaniVerma @troublemagnet |
@shreyateeza I like the idea but please implement it as well. Provide the code for the same. This will be counted for #2 and the code for #17. |
Solves a part of issue #2
What all changes are included in this PR?
Is there anything left to be done in the addressed issue? If yes, then state the remaining tasks here.
This PR solves a part of issue #2