Add attachment management to MKVFile and enhance tests #75
+766
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce attachment handling in MKVFile with methods to add, remove, and manipulate attachments. Add corresponding tests for attachment workflows and preservation. Cleanup dependencies and adjust version constraints in related configuration files.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
===========================================
+ Coverage 67.01% 78.22% +11.21%
===========================================
Files 10 10
Lines 958 1038 +80
===========================================
+ Hits 642 812 +170
+ Misses 316 226 -90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduce tests for MKVFile methods including chapter, tag, link, and split operations. Add tests for new MKVAttachment properties: `source_id` and `source_file`. These enhancements improve test coverage and ensure functionality integrity.
Added `from __future__ import annotations` to improve forward compatibility with type hints. This ensures the tests remain compatible with newer Python versions.
The `strict` argument was removed from `zip` calls across multiple functions, ensuring compatibility with Python versions that do not support it. Additionally, redundant comments in test cases were removed for cleaner and more focused code.
Ensure the attach_once property is correctly set and modified. This test covers True, False, and None states to verify proper functionality.
# Conflicts: # pyproject.toml
Introduce handling for empty attachment lists when `_info_json` is present, ensuring proper exclusion commands. Simplify and improve test cases for attachment workflows, including preservation and removal scenarios.
… accepting master changes
…lated tests - Introduced `file_first_occurrence` to track unique file paths for improved attachment processing. - Streamlined attachment exclusion logic to ensure accuracy when `_info_json` is present. - Refined test cases to validate attachment addition, removal, and preservation workflows, including edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce attachment handling in MKVFile with methods to add, remove, and manipulate attachments. Add corresponding tests for attachment workflows and preservation. Cleanup dependencies and adjust version constraints in related configuration files.