Add remediation messages to GGclient #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnareoh
changed the title
fnareoh
force-pushed
the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
from
180040f
to
1837053
Compare
fnareoh
force-pushed
the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
from
1837053
to
4814afd
Compare
2 tasks
...40701_180056_fnareoh_scrt_4626_ggshield_display_custom_remediation_message_in_ggshield_if.md
Outdated
Show resolved
Hide resolved
fnareoh
force-pushed
the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
2 times, most recently
from
59948ac
to
4d3bae8
Compare
pierrelalanne
approved these changes
Jul 19, 2024
fnareoh
force-pushed
the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
from
4d3bae8
to
cff097c
Compare
fnareoh
force-pushed
the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
from
cff097c
to
6b57cef
Compare
fnareoh
deleted the
garancegourdel/scrt-4626-ggshield-display-custom-remediation-message-in-ggshield-if
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add a new dataclass
RemediationMessagesused in theGGClientto store information given by the metadata endpoint and if the remediation message are not part of the API answer the default are used.This change is meant to be used with GitGuardian/ggshield#928 .