Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#574) Exclude all issues with label #575

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Feb 8, 2024

Description

This updates the handling on how we are excluding labels when generating
release notes.
This allows issues to be assigned with a normal label, but still be
excluded if a different label is listed in the exclusion list.

Related Issue

fixes #574

Motivation and Context

Previously you would need to add and remove labels between drafting a
release notes.

How Has This Been Tested?

This has been tested by running through scenarios locally using my FakeTestRepository

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdmiringWorm AdmiringWorm force-pushed the AdmiringWorm/issue574 branch from 9fff4cf to 3fc74b5 Compare February 8, 2024 15:44
@AdmiringWorm AdmiringWorm marked this pull request as ready for review February 8, 2024 16:07
@AdmiringWorm AdmiringWorm self-assigned this Feb 8, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 February 8, 2024 16:07
This updates the handling on how we are excluding labels when generating
release notes.
This allows issues to be assigned with a normal label, but still be
excluded if a different label is listed in the exclusion list.

Previously you would need to add and remove labels between drafting a
release notes.
@gep13 gep13 force-pushed the AdmiringWorm/issue574 branch from 3fc74b5 to 322d3f0 Compare March 9, 2024 18:08
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Mar 9, 2024

@AdmiringWorm thank you for getting this added! This will be a big help!

@gep13 gep13 enabled auto-merge March 9, 2024 18:09
@gep13
Copy link
Member

gep13 commented Mar 9, 2024

The GitHub Actions build seems to have stalled, so going to move forward with getting this merged, rather than wait for it to complete.

@gep13 gep13 disabled auto-merge March 9, 2024 18:26
@gep13 gep13 merged commit 44e8ed0 into GitTools:develop Mar 9, 2024
1 of 2 checks passed
gittools-bot pushed a commit that referenced this pull request Mar 9, 2024
Merge pull request #575 from AdmiringWorm/AdmiringWorm/issue574

(#574) Exclude all issues with label
@AdmiringWorm AdmiringWorm deleted the AdmiringWorm/issue574 branch March 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception is thrown when issue has labels in include and exclude list
2 participants