(#578) Bump Octokit to 10.0.0 to fix oversized ints #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoike
changed the title
|
@gep13 sorry to bother you. It would be great to get a review and a release on this one. |
|
I added a fix to my fork and sent in a PR to @DavidBoike DavidBoike#1 |
|
Verified that this version gets us unblocked. We are currently using a preview build of this branch |
|
@DavidBoike thank you very much for raising this PR, it is much appreciated. Thanks to @danielmarbach and @arturcic for taking this for a spin, and verifying that this fixes the upstream issue in Octokit. |
|
@DavidBoike thanks again for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumped Octokit to 10.0.0 to solve #578
Related Issue
#578
Motivation and Context
#578 prevents issue data from being fetched from GitHub due to issue/PR Id values that were previously
intnow beinglong.How Has This Been Tested?
Not sure testing this is really possible or appropriate. GitReleaseManager doesn't need the issue Id but the deserialization of the Issue data fails without the fix.
I did grab the CI-created NuGet package to test within our own environment to make sure it fixes the bug for us. That is not yet complete.
Screenshots (if appropriate):
Checklist: