Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Octokit reference and change IssueComment.Id to long #599

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Jericho
Copy link
Contributor

@Jericho Jericho commented Jun 20, 2024

Resolves #598

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

To addresses issues with int overflows. This was fixed in Octokit by
changing int to long, in some places.

In addition, changes IssueComment.Id to long to match the underlying
type.
@gep13 gep13 force-pushed the issuecomment_id_to_long branch from ebe37eb to 310d837 Compare July 9, 2024 19:44
There seems to be an error uploading reports to Codecov in the recent
builds. Rather than try to fix this just now, let's simply skip it, as
it isn't a requirement for just now.
@gep13 gep13 enabled auto-merge July 9, 2024 19:55
@gep13 gep13 merged commit a07fc87 into GitTools:develop Jul 9, 2024
2 checks passed
gittools-bot pushed a commit that referenced this pull request Jul 9, 2024
Merge pull request #599 from Jericho/issuecomment_id_to_long

Upgrade Octokit reference and change IssueComment.Id to long
@Jericho Jericho deleted the issuecomment_id_to_long branch July 10, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value was either too large or too small for an Int32
2 participants