Support C# format strings in config

[9swampy]

Description

Support C# format strings in config

Related Issue

Fixes #4156

Motivation and Context

#4156

How Has This Been Tested?

I've implemented a number of formatters and added scenario coverage for implementation but a 4-eyes verification and feedback on appropriateness of scenarios included (or not) would be welcome. The specific scenrio noted on the wish-issue tested here and here.

I've an aversion to Helper classes but that's where I've dropped all this as an extension of the original StringFormatWith but please redirect if it should live elsewhere (or just needs some structure).

Screenshots (if appropriate):

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[arturcic]

please rebase and resolve the conflicts

[asbjornu]

Awesome work! ❤️

[9swampy]

The type or namespace name 'Formatting' does not exist in the namespace 'GitVersion' (are you missing an assembly reference?)

Unclear what's gone wrong here. Clearly that's what the PR introduces and VS is happy. Is there something in the pipeline to prevent unapproved namespace additions?

[asbjornu]

Weird. Not that I know of. @arturcic, do you have an idea?

[9swampy]

Twigged what was going on. Needed to link added files in Common.csproj.

[9swampy]

There's still something messed up in the pipeline though. Now CI's not happy with the Common.csproj.

• If I only add the 1 line needed and keep 2-space indent consistent then I get a single whole-file conflict,
• if I reformat the whole file to 4-space indent to align with what the CI expected to avoid the "conflict" then I get 3 conflicts in the same file.

Really don't see what would make CI happy, so have reverted back to minimal delta of not changing the indent irrespective of what CI expects. When you eyeball the "Resolve conflict" let me know if there's something I need to do?

[arturcic]

There's still something messed up in the pipeline though. Now CI's not happy with the Common.csproj.

• If I only add the 1 line needed and keep 2-space indent consistent then I get a single whole-file conflict,
• if I reformat the whole file to 4-space indent to align with what the CI expected to avoid the "conflict" then I get 3 conflicts in the same file.

Really don't see what would make CI happy, so have reverted back to minimal delta of not changing the indent irrespective of what CI expects. When you eyeball the "Resolve conflict" let me know if there's something I need to do?

I probably missed it, but what's the reason for another csproj? Why not in the Core?

[9swampy]

I didn't add the csproj, I just added one line but something odd's going on in the pipeline. I added 1 line keeping true to the 2 space indent, but the CI pipe detects a conflict expecting everything to be 4 space indent (which isn't what the current check in is at all). Doesn't make sense, it's as if the prior file is being formatted and changed to 4 space indent BEFORE determining if there's a conflict.

[asbjornu]

Besides the build failure, this is looking really good! The only missing part is documentation.

[arturcic]

@9swampy if you don't mind I'll have a review of this in 2 weeks time as I'm on vacation. I need to understand it a bit in detail the changes as there is a chance we will need to maintain these changes.

[phatcher]

Can I also suggest adding some tests that use the zero-suppression syntax so that we can get versions without a commits number e.g.

[TestCase(0, "{0:0000}", "0000")]
[TestCase(1, "{0:0000}", "0001")]
[TestCase(0, "{0:-0000;;''}", "")]
[TestCase(1, "{0:-0000;;''}", "-0001")]
public void ZeroFormatting(int value, string template, string expected)
{
    var candidate = string.Format(template, value);

    Assert.That(candidate, Is.EqualTo(expected));
}