Fix computed revision cache in v1 #3142

gregberge · 2025-04-11T10:53:17Z

In v1, we consider revision as immutable but it's not when computed. To mitigate that, we pass some tags when we fetch a computed revision, so it's not immutable.

changeset-bot · 2025-04-11T10:53:20Z

⚠️ No Changeset found

Latest commit: 617e385

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-04-11T10:57:43Z

Summary of the deployments:

Version 1

Version	URL	Status
Latest commit	https://2fa8a221.gitbook-open.pages.dev	✅
PR	https://pr3142.gitbook-open.pages.dev	✅

Version 2

Version	URL	Status
Vercel	https://gitbook-v2-aytxo2qxu-gitbook.vercel.app	✅
Cloudflare	https://30b36dc7-gitbook-open-v2-preview.gitbook.workers.dev	✅

Test content

Site	`v1`	`2v`	`2c`
GitBook	https://2fa8a221.gitbook-open.pages.dev/docs.gitbook.com	https://gitbook-v2-aytxo2qxu-gitbook.vercel.app/url/docs.gitbook.com	https://30b36dc7-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E	https://2fa8a221.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open	https://gitbook-v2-aytxo2qxu-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open	https://30b36dc7-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

SamyPesse

Looks good, but we need to find a way to preserve all existing cache (99.999% of the site have no openapi).

packages/gitbook/src/lib/api.ts

argos-ci · 2025-04-11T14:34:27Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
customers-v1 (Inspect)	⚠️ Changes detected (Review)	3 changed, 36 removed, 9 failures	Apr 17, 2025, 7:33 AM
customers-v2 (Inspect)	⚠️ Changes detected (Review)	88 changed	Apr 17, 2025, 7:33 AM
v2-vercel (Inspect)	✅ No changes detected	3 failures	Apr 17, 2025, 7:35 AM

SamyPesse

Overall looks good, but we'll have to monitor very closely after deployment, so I'm not approving yet as I'm not on the laptop.

Also it looks like the code is incomplete

packages/gitbook/src/lib/api.ts

SamyPesse

At this stage, it'll still bust the cache for all spaces

packages/gitbook/src/lib/api.ts

packages/gitbook/src/lib/v1.ts

gregberge · 2025-04-16T07:04:38Z

At this stage, it'll still bust the cache for all spaces

@SamyPesse it's fixed.

SamyPesse

Looks good

SamyPesse · 2025-04-17T14:29:04Z

packages/gitbook/src/lib/api.ts

        return cacheResponse(response, {
            ...(fetchOptions.metadata ? cacheTtl_7days : cacheTtl_1day),
-            data: response.data.pages,
+            data: { ...response.data, tags: getResponseCacheTags(response) },


Isn't it an array usually ?

gregberge · 2025-04-18T07:32:50Z

As I said @SamyPesse I don't think it's a good idea to do that.

gregberge deployed to 2v-preview April 11, 2025 10:53 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 10:53 — with GitHub Actions View deployment

gregberge deployed to 1c-preview April 11, 2025 10:53 — with GitHub Actions View deployment

gregberge force-pushed the fix-revision-cache-v1 branch from a30e71c to faa4e1b Compare April 11, 2025 10:58

gregberge deployed to 1c-preview April 11, 2025 10:58 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 10:58 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 11, 2025 10:58 — with GitHub Actions View deployment

gregberge requested a review from SamyPesse April 11, 2025 10:59

gregberge force-pushed the fix-revision-cache-v1 branch from faa4e1b to eebb5a3 Compare April 11, 2025 11:00

gregberge deployed to 1c-preview April 11, 2025 11:00 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 11, 2025 11:00 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 11:00 — with GitHub Actions View deployment

gregberge force-pushed the fix-revision-cache-v1 branch from eebb5a3 to 83ef048 Compare April 11, 2025 11:03

gregberge deployed to 2c-preview April 11, 2025 11:04 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 11, 2025 11:04 — with GitHub Actions View deployment

gregberge deployed to 1c-preview April 11, 2025 11:04 — with GitHub Actions View deployment

SamyPesse reviewed Apr 11, 2025

View reviewed changes

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

gregberge force-pushed the fix-revision-cache-v1 branch from 46cda13 to 61ccfb6 Compare April 11, 2025 11:47

gregberge deployed to 2v-preview April 11, 2025 11:47 — with GitHub Actions View deployment

gregberge deployed to 1c-preview April 11, 2025 11:47 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 11:47 — with GitHub Actions View deployment

gregberge force-pushed the fix-revision-cache-v1 branch from 61ccfb6 to e9dc6ad Compare April 11, 2025 14:24

gregberge deployed to 1c-preview April 11, 2025 14:24 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 14:24 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 11, 2025 14:24 — with GitHub Actions View deployment

gregberge force-pushed the fix-revision-cache-v1 branch from e9dc6ad to f140093 Compare April 11, 2025 14:30

gregberge deployed to 1c-preview April 11, 2025 14:30 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 11, 2025 14:30 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 11, 2025 14:30 — with GitHub Actions View deployment

SamyPesse reviewed Apr 11, 2025

View reviewed changes

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

gregberge force-pushed the fix-revision-cache-v1 branch from f140093 to e7b7c32 Compare April 12, 2025 15:24

gregberge deployed to 1c-preview April 12, 2025 15:24 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 12, 2025 15:24 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 12, 2025 15:24 — with GitHub Actions View deployment

SamyPesse reviewed Apr 16, 2025

View reviewed changes

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

packages/gitbook/src/lib/v1.ts Show resolved Hide resolved

gregberge deployed to 1c-preview April 16, 2025 07:04 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 16, 2025 07:04 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 16, 2025 07:04 — with GitHub Actions View deployment

gregberge requested a review from SamyPesse April 16, 2025 07:04

SamyPesse approved these changes Apr 16, 2025

View reviewed changes

gregberge force-pushed the fix-revision-cache-v1 branch from 4cce632 to d5e11b8 Compare April 17, 2025 07:07

gregberge deployed to 1c-preview April 17, 2025 07:07 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 17, 2025 07:07 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 17, 2025 07:07 — with GitHub Actions View deployment

Fix computed revision cache in v1

617e385

gregberge force-pushed the fix-revision-cache-v1 branch from d5e11b8 to 617e385 Compare April 17, 2025 07:24

gregberge deployed to 1c-preview April 17, 2025 07:24 — with GitHub Actions View deployment

gregberge deployed to 2c-preview April 17, 2025 07:24 — with GitHub Actions View deployment

gregberge deployed to 2v-preview April 17, 2025 07:24 — with GitHub Actions View deployment

SamyPesse reviewed Apr 17, 2025

View reviewed changes

gregberge closed this Apr 18, 2025

Fix computed revision cache in v1 #3142

Fix computed revision cache in v1 #3142

Uh oh!

Conversation

gregberge commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Version 1

Version 2

Test content

Uh oh!

SamyPesse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

argos-ci bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SamyPesse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SamyPesse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregberge commented Apr 16, 2025

Uh oh!

SamyPesse left a comment

Choose a reason for hiding this comment

Uh oh!

SamyPesse Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

gregberge commented Apr 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gregberge commented Apr 11, 2025 •

edited

Loading

changeset-bot bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

argos-ci bot commented Apr 11, 2025 •

edited

Loading