Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting content type for github webhook #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

choxi
Copy link

@choxi choxi commented May 16, 2017

GitHub sends webhooks with an "application/x-www-form-urlencoded" by default, but this crashes the nuts server because it's excepting the content type to be "application/json". There's a dropdown to change the content type, but since there's no error message in the Heroku logs it was a little tricky to track down why the webhook wasn't working:

github config

It'd be helpful to include this information in the docs so others don't get blocked by the same problem.

@AaronO
Copy link
Contributor

AaronO commented Aug 9, 2017

@choxi Maybe the better fix would be for nuts to support both encodings, that would make more sense and be less error prone.

(Assuming the x-www-form-urlencoded isn't lacking any info or annoying to parse)

@loprima-l
Copy link

Hi, I merged the project to a new repo to start maintain it, I would be glad if you can put your pull request here : https://github.com/loprima-l/nuts-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants