Skip to content

Commit

Permalink
docs: use apps/v1 instead of extensions/v1beta1 in Deployment examples
Browse files Browse the repository at this point in the history
The extensions/v1beta1 API is deprecated for Deployment and with 1.16 is
not served by default anymore. This breaks the examples on k8s 1.16.

See this blog post for details on the deprecations:

https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
  • Loading branch information
reegnz committed Oct 15, 2019
1 parent cec75d7 commit aff20c1
Show file tree
Hide file tree
Showing 26 changed files with 258 additions and 70 deletions.
2 changes: 1 addition & 1 deletion docs/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ According to the `nginx-ingress-controller` [docs](https://github.com/kubernetes
For example if your `nginx-ingress-controller` Service's name is `nginx-ingress-controller-svc` and it's in the `default` namespace the start of your resource YAML might look like the following. Note the second to last line.

```
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx-ingress-controller
Expand Down
15 changes: 12 additions & 3 deletions docs/tutorials/alibabacloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,16 @@ Then apply one of the following manifests file to deploy ExternalDNS.

### Manifest (for clusters without RBAC enabled)
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -169,13 +172,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -266,11 +272,14 @@ spec:
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
15 changes: 12 additions & 3 deletions docs/tutorials/aws-sd.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,16 @@ Then apply the following manifest file to deploy ExternalDNS.
### Manifest (for clusters without RBAC enabled)

```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -128,13 +131,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -177,11 +183,14 @@ spec:
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
15 changes: 12 additions & 3 deletions docs/tutorials/aws.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,16 @@ For clusters with RBAC enabled, be sure to choose the correct `namespace`.

### Manifest (for clusters without RBAC enabled)
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -135,13 +138,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -229,11 +235,14 @@ spec:
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
20 changes: 16 additions & 4 deletions docs/tutorials/azure.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,16 @@ Then apply one of the following manifests file to deploy ExternalDNS.
### Manifest (for clusters without RBAC enabled)
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -243,13 +246,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -313,13 +319,16 @@ subjects:
- kind: ServiceAccount
name: external-dns
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -356,11 +365,14 @@ $ kubectl create -f externaldns.yaml
Create a service file called 'nginx.yaml' with the following contents:
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
15 changes: 12 additions & 3 deletions docs/tutorials/cloudflare.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@ Then apply one of the following manifests file to deploy ExternalDNS.
### Manifest (for clusters without RBAC enabled)

```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -97,13 +100,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand All @@ -130,11 +136,14 @@ spec:
Create a service file called 'nginx.yaml' with the following contents:
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
10 changes: 8 additions & 2 deletions docs/tutorials/contour.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@ It is meant to supplement the other provider-specific setup tutorials.

### Manifest (for clusters without RBAC enabled)
```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -73,13 +76,16 @@ subjects:
name: external-dns
namespace: default
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down
10 changes: 8 additions & 2 deletions docs/tutorials/designate.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,16 @@ It is important to manually create all the zones that are going to be used for k
Create a deployment file called `externaldns.yaml` with the following contents:

```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: external-dns
spec:
strategy:
type: Recreate
selector:
matchLabels:
app: external-dns
template:
metadata:
labels:
Expand Down Expand Up @@ -85,11 +88,14 @@ $ kubectl create -f externaldns.yaml
Create a service file called 'nginx.yaml' with the following contents:

```yaml
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx
spec:
selector:
matchLabels:
app: nginx
template:
metadata:
labels:
Expand Down
Loading

0 comments on commit aff20c1

Please sign in to comment.