Add secretConfiguration.subPath to mount specific files from secret (k…

…ubernetes-sigs#3227) * Add secretConfiguration.subPath to mount specific files from secret * Apply suggestions from code review Co-authored-by: Steve Hipwell <[email protected]> Co-authored-by: Steve Hipwell <[email protected]>
Gitopolis · Dec 12, 2022 · c887237 · c887237
1 parent e0b9399
commit c887237
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -74,3 +74,4 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart
 | `secretConfiguration.enabled`     | Enable additional secret configuration.                                                                                                                                                                                                                                                                               | `false`                                |
 | `secretConfiguration.mountPath`   | Mount path of secret configuration secret (this can be templated).                                                                                                                                                                                                                                                    | `""`                                   |
 | `secretConfiguration.data`        | Secret configuration secret data. Could be used to store DNS provider credentials.                                                                                                                                                                                                                                    | `{}`                                   |
+| `secretConfiguration.subPath`        | Sub-path of secret configuration secret (this can be templated).                                                                                                                                                                                                                                        | `""`                     |
diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -109,6 +109,9 @@ spec:
             {{- if .Values.secretConfiguration.enabled }}
             - name: secrets
               mountPath: {{ tpl .Values.secretConfiguration.mountPath $ }}
+            {{- with .Values.secretConfiguration.subPath }}
+              subPath: {{ tpl . $ }}
+            {{- end }}
             {{- end }}
             {{- with .Values.extraVolumeMounts }}
             {{- toYaml . | nindent 12 }}

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -131,7 +131,12 @@ extraArgs: []
 secretConfiguration:
   enabled: false
   mountPath: ""
+  subPath: ""
   data: {}
+    # credentials: |
+    #   [default]
+    #   aws_access_key_id = $SECRET_ACCESS_KEY
+    #   aws_secret_access_key = $SECRET_ACCESS_KEY
 
 deploymentStrategy:
   type: Recreate