Skip to content

Commit

Permalink
Fix msrv: Run msrv checks with minimal versions
Browse files Browse the repository at this point in the history
Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by gix.

Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.
  • Loading branch information
NobodyXu authored Aug 23, 2024
1 parent 46cd1ae commit 4ff19f8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/msrv.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
- uses: actions/checkout@v4
- uses: extractions/setup-just@v2
- run: |
rustup toolchain install ${{ env.rust_version }} --profile minimal --no-self-update
rustup toolchain install ${{ env.rust_version }} nightly --profile minimal --no-self-update
rustup default ${{ env.rust_version }}
cargo +nightly update -Zminimal-versions
- run: just ci-check-msrv

0 comments on commit 4ff19f8

Please sign in to comment.