Fix gix credential fill
to accept protocol+host without URL field
#2191
+161
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2190
Problem
gix credential fill
incorrectly required theurl
field to be present, even when bothprotocol
andhost
fields were provided. This differs from Git's behavior and breaks compatibility with credential helpers that only provide individual fields.According to the git-credential documentation:
This implies that
url
should be optional when the constituent parts (protocol
andhost
) are available.Before
After
Changes
gix-credentials/src/program/main.rs
to accept eitherurl
OR bothprotocol
andhost
destructure_url_in_place
method to construct URLs from individual components whenurl
field is missingCompatibility
url
-based workflows continue to work unchangedgit credential fill
behavior exactlyprotocol
,host
,path
, andusername
All existing tests continue to pass, and 7 new test cases ensure the new functionality works correctly.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.