Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

F 2544 ability to withdraw any tokens bigger than withdraw limit #2549

Conversation

RamRamez
Copy link
Collaborator

Issue #2544

@netlify
Copy link

netlify bot commented Sep 27, 2021

✔️ Deploy Preview for giveth-dapp ready!

🔨 Explore the source changes: 9b92119

🔍 Inspect the deploy log: https://app.netlify.com/sites/giveth-dapp/deploys/61535bcda58db900073e480d

😎 Browse the preview: https://deploy-preview-2549--giveth-dapp.netlify.app/

@mohammadranjbarz
Copy link
Collaborator

@RamRamez
You didnt handle withdraw when user want to withdraw from /my-traces

Screen Shot 1400-07-06 at 17 03 25

@mohammadranjbarz
Copy link
Collaborator

@RamRamez @MoeNick
For when we can just withdraw one token, is this sentence ok ?
Select tokens to withdraw this message has mislead me as a user

Screen Shot 1400-07-06 at 17 05 28

@MoeNick
Copy link
Member

MoeNick commented Sep 28, 2021

Do you have any suggestion @mohammadranjbarz ?

@RamRamez
Copy link
Collaborator Author

RamRamez commented Sep 28, 2021

@mohammadranjbarz
When there is only one token to withdraw, that token is selected by default and select component is disabled.
I can remove select component in this case and put just a text instead

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 28, 2021

Do you have any suggestion @mohammadranjbarz ?

Something like this : You just can withdraw your withdrwableToken tokens,

PS : Amin told me review this PR, so I said my suggestions, but if you think it's ok we can leave it as it is

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 28, 2021

@mohammadranjbarz When there is only one token to withdraw, that token is selected by default and select component is disabled. I can remove select component in this case and put just a text instead

I think it's good, @MoeNick What do you think about it?

@RamRamez
Copy link
Collaborator Author

@RamRamez You didnt handle withdraw when user want to withdraw from /my-traces

Screen Shot 1400-07-06 at 17 03 25

Yes you're right. I fixed it.

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 29, 2021

@RamRamez You didnt handle withdraw when user want to withdraw from /my-traces
Screen Shot 1400-07-06 at 17 03 25

Yes you're right. I fixed it.

It's ok now
but I get an error when want to disburse money
(When I have just one token in my trace collect is ok)
Screen Shot 1400-07-07 at 09 42 04 (2)

@RamRamez
Copy link
Collaborator Author

@mohammadranjbarz I simulated the same situation and it was ok for me. Maybe it was a MetaMask error or something. Can you test again?

Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks good to me

Copy link
Collaborator

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamRamez
Thanks, it seems good

@mohammadranjbarz mohammadranjbarz merged commit cfe80a8 into develop Sep 29, 2021
@aminlatifi aminlatifi deleted the F_2544_ability_to_withdraw_any_tokens_bigger_than_withdraw_limit branch November 8, 2021 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants