-
Notifications
You must be signed in to change notification settings - Fork 229
F 2544 ability to withdraw any tokens bigger than withdraw limit #2549
F 2544 ability to withdraw any tokens bigger than withdraw limit #2549
Conversation
✔️ Deploy Preview for giveth-dapp ready! 🔨 Explore the source changes: 9b92119 🔍 Inspect the deploy log: https://app.netlify.com/sites/giveth-dapp/deploys/61535bcda58db900073e480d 😎 Browse the preview: https://deploy-preview-2549--giveth-dapp.netlify.app/ |
@RamRamez |
Do you have any suggestion @mohammadranjbarz ? |
@mohammadranjbarz |
Something like this : You just can withdraw your withdrwableToken tokens, PS : Amin told me review this PR, so I said my suggestions, but if you think it's ok we can leave it as it is |
I think it's good, @MoeNick What do you think about it? |
Yes you're right. I fixed it. |
It's ok now |
@mohammadranjbarz I simulated the same situation and it was ok for me. Maybe it was a MetaMask error or something. Can you test again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RamRamez
Thanks, it seems good
Issue #2544