Fix small donation amount

[kkatusic]

• When Users attempt to donate with Solana Devnet, the calculations for Giveth Givbacks after selecting any of the percentage is not correct (the amount being donated to Giveth shown on the preview modal is also wrong) impact-graph#1710

This PR fix minimal amount donation issue when user enter that number as donation number and choose to give some percentage to the Giveth. Than that amount to GIveth will be 0 and that's not an option. If donation to giveth as number is 0 than there won't be any donation to GIveth.

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Introduced givethDonationAmount property for enhanced donation management in the donation components.
  • Updated donation validation logic to ensure both donationToGiveth and givethDonationAmount must be greater than zero for valid donations.
  • Improved calculation for givethDonationAmount to provide more accurate donation information.

• Bug Fixes

  • Enhanced control flow and state handling for donations, ensuring accurate processing based on user input.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2024 1:25pm

[coderabbitai]

Walkthrough

The updates across the donation-related components introduce a new property, givethDonationAmount, enhancing their functionality. This addition allows for better management of donation amounts by adjusting state and control flow based on user input. The changes promote a modular approach, improving validation logic and ensuring a more accurate representation of donation data in the user interface.

Changes

Files and Paths	Change Summary
src/components/views/donate/DonateToGiveth.tsx	Added givethDonationAmount to IDonateToGiveth interface; modified logic to manage donation amounts based on this new state.
src/components/views/donate/OnTime/DonateModal.tsx	Introduced givethDonationAmount to IDonateModalProps; updated logic for isDonatingToGiveth to consider both donationToGiveth and givethDonationAmount.
src/components/views/donate/OnTime/OneTimeDonationCard.tsx	Imported calcDonationShare for more modular donation calculations; updated control flow to compute and pass givethDonationAmount to relevant components.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OneTimeDonationCard
    participant DonateModal
    participant DonateToGiveth

    User->>OneTimeDonationCard: Input Donation Amount
    OneTimeDonationCard->>OneTimeDonationCard: Calculate `givethDonationAmount`
    OneTimeDonationCard->>DonateModal: Pass `givethDonationAmount`
    OneTimeDonationCard->>DonateToGiveth: Pass `givethDonationAmount`
    DonateModal->>DonateModal: Check if Valid Donation
    DonateModal->>User: Show Donation Confirmation

Loading

Poem

In the meadow where donations grow,
A rabbit hops with a happy glow.
With givethDonationAmount, so bright,
We share our joys and make things right.
Let's celebrate this generous spree,
For every hop brings hope, you see! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a92102e and 77ac4c8.

Files selected for processing (2)

• src/components/views/donate/DonateToGiveth.tsx (3 hunks)
• src/components/views/donate/OnTime/OneTimeDonationCard.tsx (4 hunks)

Files skipped from review as they are similar to previous changes (2)

• src/components/views/donate/DonateToGiveth.tsx
• src/components/views/donate/OnTime/OneTimeDonationCard.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mohammadranjbarz]

Thanks @kkatusic LGTM