-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into develop #4709
Merged
Merge main into develop #4709
Changes from 62 commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
69f1ca1
update apollo client link
MohammadPCh db52608
remove log
MohammadPCh ba03fa2
disable ethdenver
MohammadPCh f20895c
fix importing PFP_ABI
MohammadPCh 659a602
remove unused vars
MohammadPCh d4a3b76
Merge branch 'main' into hotfix/fix-apollo-errors
MohammadPCh b8ff375
Merge pull request #4699 from Giveth/develop
Meriem-BM 91b4779
fix givbacks toast button width
divine-comedian 1854c08
Merge pull request #4708 from Giveth/hotfix-givbackstoast-button
Meriem-BM a29c603
prevent projects with Endaoment label from showing recurring donation…
divine-comedian 57b2ec9
Merge pull request #4710 from Giveth/hotfix-prevent-endaoment-recurri…
divine-comedian acf812f
Update giv-palooza-bg1.svg
mateodaza b0bee5e
updating sponsors
mateodaza a5af3a5
Merge pull request #4713 from Giveth/updating-qf-banner
mateodaza 924f7e3
comment out recurring donation default
divine-comedian f1e5c87
Merge pull request #4717 from Giveth/comment-out-recurring-donation-d…
divine-comedian 75e9749
adding safe back
mateodaza 5894a46
Merge pull request #4725 from Giveth/multisig-hotfix
mateodaza 168889c
Fix Stellar donation card ui things regarding QF
mohammadranjbarz 1c52ecf
Change qf guid hin in stellar donate page
mohammadranjbarz 99f22bb
Undo passport banner changes
mohammadranjbarz 5910f31
Fix linter errors
mohammadranjbarz 8050d7f
fix: add condition to hide QFSection when its stellar chain
Meriem-BM 6f1a6b1
fix: linter error
Meriem-BM 0dc52e5
fix: showing Toast to switch network when Stellar is picked
Meriem-BM 6351908
fix: linter error
Meriem-BM 30a40ba
fix: hide AlreadyDonated toast
Meriem-BM e81845a
Merge pull request #4734 from Giveth/4732_fix_stellar_doante_card_ui
Meriem-BM d1ae4e8
Modify givbacks page to be compatible with givback v2
mohammadranjbarz 98eae3b
Show allocatedGivTokens in givbacks page
mohammadranjbarz 69a43c9
Fix build error
mohammadranjbarz 6e9ec16
Remove console.log
mohammadranjbarz 6295e1b
Add minimum value usd for givback eligible
mohammadranjbarz 7fac316
Fix lint error
mohammadranjbarz 47314e5
Fix lint error
mohammadranjbarz 5597777
Change givPower page text adjustments
mohammadranjbarz cd04f3a
Change text of allocated GIV tokens so far
mohammadranjbarz c8078ba
donate page new design
RamRamez 18bff9d
Merge branch 'refs/heads/donate-page-new-design' into release_17_sep
RamRamez 6f91c80
fix eslint error
RamRamez 7bf5df3
Remove title of giv power boosting
mohammadranjbarz adfce35
Merge branch 'release_17_sep' of github.com:Giveth/giveth-dapps-v2 in…
mohammadranjbarz 4bcffdd
change givback verified_owner copy
RamRamez c333566
add GIVBACKS_DONATION_QUALIFICATION_VALUE_USD constant
RamRamez 70fe9f3
update verified_public givback copy
RamRamez 8fbf3c3
Fix WALLET_ADDRESS_IS_VALID query params
mohammadranjbarz d99b794
add min givbacks badge
RamRamez dc926a0
Merge remote-tracking branch 'origin/release_17_sep' into release_17_sep
RamRamez 768d37f
add min givbacks badge active color
RamRamez 90872b0
add givbacks badge conditions
RamRamez 9aa5086
Merge pull request #4743 from Giveth/release_17_sep
RamRamez 012acd8
fix boost button position
RamRamez 8ed4ebb
Merge pull request #4746 from Giveth/fix-boost-button-position
RamRamez 99316ca
add donor survey banner
divine-comedian 5411c71
Merge branch 'main' into hotfix/fix-apollo-errors
MohammadPCh 650687c
fix build issue
MohammadPCh a628cd2
fix test page
MohammadPCh fe6cd02
Merge pull request #4649 from Giveth/hotfix/fix-apollo-errors
MohammadPCh a5a5314
remove subgraph log
MohammadPCh 9cc353e
Trigger fresh rebuild on Vercel after changing ENV variable
geleeroyale 03c83bf
add fetchTokenBalances
MohammadPCh df9ffd7
change name to services
MohammadPCh 33bec2b
parse as bigint
MohammadPCh 410147c
return zero for undefined balances
MohammadPCh 81f53f5
use fetchTokenBalances
MohammadPCh a1194c0
remove logs
MohammadPCh 973c884
update translation
MohammadPCh 8970195
Merge pull request #4767 from Giveth/update-translations
MohammadPCh b88040d
Merge branch 'main' into feat/update-fetching-token-balance
MohammadPCh 1700f6b
Merge pull request #4766 from Giveth/feat/update-fetching-token-balance
MohammadPCh 33ba3e1
GIVbacks V2 and Stellar hotfixes (#4748)
RamRamez 390a1c9
remove package-lock.json
RamRamez 0fedad6
add giveth.io to next.config.js
RamRamez f7179a7
Merge pull request #4777 from Giveth/remove-package-lock.json
RamRamez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { gql } from '@apollo/client'; | ||
|
||
export const FETCH_ALLOCATED_GIVBACKS = gql` | ||
query allocatedGivbacks($refreshCache: Boolean) { | ||
allocatedGivbacks(refreshCache: $refreshCache) { | ||
usdValueSentAmountInPowerRound | ||
allocatedGivTokens | ||
givPrice | ||
date | ||
} | ||
} | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Issues Identified with Campaign Data Fetching
The
campaign
prop is still being passed to theEthDenverView
component despite disabling its data fetching:pages/landings/ethdenver.tsx
,<EthDenverView campaign={campaign} />
is called, butcampaign
is no longer provided ingetStaticProps
.EthDenverView
receiving an undefined or emptycampaign
prop, potentially causing rendering issues.Recommended Actions:
EthDenverView
Component:campaign
prop is absent or null.IEthDenverProps
Interface:campaign
prop if it's no longer used.getStaticProps
:revalidate
property in both success and error cases.Analysis chain
Review the implications of disabling campaign data fetching
The changes in the
getStaticProps
function have several implications:props
object, which may affect the rendering of theEthDenverView
component.Consider the following actions:
EthDenverRoute
component to handle the case where no campaign data is provided.EthDenverView
component to ensure it can handle anull
orundefined
campaign prop.campaign
prop from theIEthDenverProps
interface if it's no longer used.revalidate
property or add it back to the success case for consistency.To verify the impact of these changes, let's analyze the
EthDenverView
component:Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 127
Script:
Length of output: 228
Script:
Length of output: 235
Script:
Length of output: 120
Script:
Length of output: 125