-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decentralized Verification: Moving from verified to vouches #4729
Changes from all commits
d4d6584
c263d97
050ca02
395de5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { | ||
Overline, | ||
FlexCenter, | ||
brandColors, | ||
IconGIVBack, | ||
} from '@giveth/ui-design-system'; | ||
import styled from 'styled-components'; | ||
import { useIntl } from 'react-intl'; | ||
|
||
export const GivBackBadge = () => { | ||
const { formatMessage } = useIntl(); | ||
return ( | ||
<Wrapper> | ||
<IconGIVBack color='white' /> | ||
<TextBadge $styleType='Small'> | ||
{formatMessage({ id: 'label.isGivbackEligible' })} | ||
</TextBadge> | ||
</Wrapper> | ||
); | ||
}; | ||
|
||
const Wrapper = styled(FlexCenter)` | ||
height: 30px; | ||
background: ${brandColors.giv[500]}; | ||
border-radius: 56px; | ||
color: white; | ||
padding: 2px 12px 0 10px; | ||
justify-content: center; | ||
margin-right: 8px; | ||
`; | ||
|
||
const TextBadge = styled(Overline)` | ||
padding-left: 0.5rem; | ||
margin-right: 5px; | ||
text-transform: uppercase; | ||
`; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,7 +80,7 @@ const CryptoDonation: FC<{ | |
const dispatch = useAppDispatch(); | ||
|
||
const { | ||
verified, | ||
isGivbackEligible, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tip Codebase Verification Inconsistent renaming of The renaming of
Analysis chainVerify the consistency and impact of the variable renaming. The renaming of Run the following script to verify the consistency and impact: Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the consistency and impact of renaming `verified` to `isGivbackEligible`.
# Test 1: Search for any remaining occurrences of `verified`. Expect: No results.
rg --type tsx --type ts --type js $'verified' -g '!yarn.lock'
# Test 2: Search for occurrences of `isGivbackEligible`. Expect: Only occurrences related to the Givback feature.
rg --type tsx --type ts --type js $'isGivbackEligible' -g '!yarn.lock' -A 5
Length of output: 191 Script: #!/bin/bash
# Description: Verify the consistency and impact of renaming `verified` to `isGivbackEligible`.
# Test 1: Search for any remaining occurrences of `verified`. Expect: No results.
rg 'verified' --glob '*.tsx' --glob '*.ts' --glob '*.js' -g '!yarn.lock'
# Test 2: Search for occurrences of `isGivbackEligible`. Expect: Only occurrences related to the Givback feature.
rg 'isGivbackEligible' --glob '*.tsx' --glob '*.ts' --glob '*.js' -g '!yarn.lock' -A 5
Length of output: 23634 |
||
id: projectId, | ||
status, | ||
addresses, | ||
|
@@ -139,7 +139,7 @@ const CryptoDonation: FC<{ | |
}); | ||
|
||
const tokenDecimals = selectedOneTimeToken?.decimals || 18; | ||
const projectIsGivBackEligible = !!verified; | ||
const projectIsGivBackEligible = !!isGivbackEligible; | ||
const { activeStartedRound } = getActiveRound(project.qfRounds); | ||
const networkId = (chain as Chain)?.id; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Inconsistent terminology change from "verified" to "vouched".
The terminology change from "verified" to "vouched" has not been consistently applied across the codebase. There are still numerous instances of "verified" in both TypeScript/JavaScript files and localization files. Please review the codebase to ensure that the terminology change is consistently applied to maintain a cohesive user experience.
Analysis chain
Verify the consistency of the terminology change.
The change from "verified" to "vouched" aligns with the PR objective. However, please ensure that this terminology change is consistently applied across the codebase and user interface to maintain a cohesive user experience.
Run the following script to verify the consistency of the terminology change:
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 47611