Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix fix getting giv price on polygon-zkevm chain #4789

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

mohammadranjbarz
Copy link
Contributor

related to #4680

I made these changes

  • As we just get price from gnosis subgraph so I removed chainId from useFetchGIVPrice() input params.
  • When we can't get give price from subgraph we attempt to get the price from coingecko

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 10:16am

Copy link
Collaborator

@MohammadPCh MohammadPCh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammadranjbarz Thanks, LGTM

@mohammadranjbarz mohammadranjbarz merged commit cb2a533 into main Sep 26, 2024
3 checks passed
@mohammadranjbarz mohammadranjbarz deleted the 4680_fix_giv_price_on_polygon_zkevm_Chain branch September 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants