When Users attempt to donate with Solana Devnet, the calculations for Giveth Givbacks after selecting any of the percentage is not correct (the amount being donated to Giveth shown on the preview modal is also wrong)

[LatifatAbdullahi]

Given that Users have connected their wallet and Signed In.
And the Network is Solana Devnet
And Users have inputted the number of tokens to be donated
When Users select a percentage to be donated to giveth
Then the Giveth donation calculated amount is still equal to the amount being donated to the Project

[divine-comedian]

@LatifatAbdullahi - you can confirm this only applies when on solana devnet? no other chains are affected by this bug?

@MohammadPCh - can you check this out or delegate it to another FE dev?

[LatifatAbdullahi]

@LatifatAbdullahi - you can confirm this only applies when on solana devnet? no other chains are affected by this bug?

@MohammadPCh - can you check this out or delegate it to another FE dev?

Yes, only on Solana Devnet

[MohammadPCh]

@lovelgeorge99 could you please take this? Thanks

[lovelgeorge99]

ok i will work on this 👍

@lovelgeorge99 could you please take this? Thanks

[maryjaf]

Could you please take a look on this comment
@lovelgeorge99
Giveth/giveth-dapps-v2#3903 (comment)

[lovelgeorge99]

@maryjaf

Earlier the logic was if the user is trying to donate 0.000001 , the giveth donation would automatically change to 0.000001 also(that is the minimum donation amount ) and total donation would be 0.000001 + 0.000001 = 0.000002 .
Since the users total donation is only 0.000001 ,he cant donate 0.000002 .

Now the new logic is that if the user is trying to donate a amount less than the minimum giveth donation amount ,giveth donation is converted to 0

[maryjaf]

Thanks @lovelgeorge99
Is this new logic and UX approved by @divine-comedian also?

[divine-comedian]

Sorry I don't understand clearly what is explained. Is it this?

• Minimum amount that can be entered on the donation input is 0.000001
• user enters to donate minimum amount - 0.000001
• has selected donate % to Giveth

Since we can't accept numbers under the minumum (e.g. 0.000001 * 5%) the giveth donation amount is then rounded up to the minimum amount? 0.000001. This means the user ends up donating 0.000002 ?

If this is true then what we should do check the box for "I do not want to support Giveth . . . " to ensure no second tx is generated and the text shown on the page makes sense.

[maryjaf]

Sorry I don't understand clearly what is explained. Is it this?

• Minimum amount that can be entered on the donation input is 0.000001
• user enters to donate minimum amount - 0.000001
• has selected donate % to Giveth

Since we can't accept numbers under the minumum (e.g. 0.000001 * 5%) the giveth donation amount is then rounded up to the minimum amount? 0.000001. This means the user ends up donating 0.000002 ?

This is the previous behavior of system in donation page,
the current behavior is like as below video

Screen.Recording.2024-08-11.at.11.51.06.AM.mov

My question is, even though the user has chosen a percentage and "Donating 15% to Giveth: 0 GIV" is shown, is the behavior accepted? @divine-comedian

• Enter 0.000001 GIV for donation
• Select 5 or 10,15 20 % for donating to Giveth
• "Donating % to Giveth" is set 0

[divine-comedian]

yes @maryjaf

[maryjaf]

This change should be reverted
@divine-comedian @lovelgeorge99
cc: @MohammadPCh

Screen.Recording.2024-08-11.at.7.21.10.PM.mov

[kkatusic]

@maryjaf you used Trust wallet? thx

[lovelgeorge99]

@maryjaf you used Trust wallet? thx

2024-08-12.10-40-37.mp4

[maryjaf]

@maryjaf you used Trust wallet? thx

2024-08-12.10-40-37.mp4

No I tested it on Metamask

[maryjaf]

Sorry I don't understand clearly what is explained. Is it this?

• Minimum amount that can be entered on the donation input is 0.000001
• user enters to donate minimum amount - 0.000001
• has selected donate % to Giveth

Since we can't accept numbers under the minumum (e.g. 0.000001 * 5%) the giveth donation amount is then rounded up to the minimum amount? 0.000001. This means the user ends up donating 0.000002 ?

This is the previous behavior of system in donation page, the current behavior is like as below video

Screen.Recording.2024-08-11.at.11.51.06.AM.mov

My question is, even though the user has chosen a percentage and "Donating 15% to Giveth: 0 GIV" is shown, is the behavior accepted? @divine-comedian

• Enter 0.000001 GIV for donation
• Select 5 or 10,15 20 % for donating to Giveth
• "Donating % to Giveth" is set 0

Actually the problem is related this new logic, in this scenario that user enters 0.000001( minimum amount of donation) and select a percentage for donating to Giveth
Based on new logic , the amount of donation to Giveth is set 0 and the reported bug happens

[kkatusic]

@divine-comedian this is how thing are sorted up, minimal GIV donation is 0.000001 (read 5 decimals zeros) and for example 5% of GIV donation to Giveth is 0.00000005 GIV (read 7 decimals zeros). App than setup GIV 5% donation to 0 and that's why the transaction fails. Why did someone implement this code, maybe there was some request for it.

Now what you want to do, to allow small amount of GIV token donation to Giveth if someone add smallest amount of "main" donation, or we can than reset the GIveth donation amount to minimal token donation amount, in this previous case it was 0.000001 ?

thx

[divine-comedian]

chatted with kechy - since this feature/bug isn't super important so let's go the way of least headache.

If the minimum donation amount if set we should set the giveth donation amount to 0 and ensure the UI elements reflect this.

• toggle the checkbox on the UI to "I don't want to make a donation to Giveth" and make sure the numbers on the UI are correct
• ensure there is no amount entered on UI for "donating to Giveth"

[divine-comedian]

@kkatusic what is the update on this issue?

[kkatusic]

@kkatusic what is the update on this issue?

this is waiting PR review :( I will ask for review

[kkatusic]

@LatifatAbdullahi you can test when you get time ;)

[LatifatAbdullahi]

@divine-comedian

These have been fulfilled

• Set the giveth donation amount to 0 and ensure the UI elements reflect this - Pass
• Toggle the checkbox on the UI to "I don't want to make a donation to Giveth" and make sure the numbers on the UI are correct - Pass
• Ensure there is no amount entered on UI for "donating to Giveth" - Pass

However at the point of Donation confirmation, it takes too long to confirm donation, over a minute, it just keeps loading continuously and my wallet is deducted without a success modal.

BukkyProject._.Giveth.-.Google.Chrome.2024-08-30.16-57-13.mp4

Cloy._.Giveth.-.Google.Chrome.2024-08-21.18-33-00.mp4

[divine-comedian]

@LatifatAbdullahi this is already done?

[LatifatAbdullahi]

@kkatusic
The issue is not fixed

[kkatusic]

@LatifatAbdullahi, ccc @divine-comedian, making donation on Solana DevNet is old issue, we didn't manage it to work, I also reported that issue on package github account:

anza-xyz/wallet-adapter#1009

I tried and succeeded to made donation on SOlana project on production and it is working fine, check images:

you decide will we wait to they fix devnet transaction problem or we will close this issue

[divine-comedian]

honestly, not very important to get solana devnet perfect, if we are sure production is working OK I think we can move on!