-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed givpower boosting related queries to improve performance #1079
Conversation
Changed power_balance_snapshot table balance column to accept null values Change take TAKE_POWER_BOOSTING_SNAPSHOT procedure to make instances of power_balance_snapshot for users has power_boosting_snapshot for each snapshot Updated tests to match these changes Ref #1067
@CarlosQ96 @MohammadPCh We must monitor database load before and after this merge |
I noticed some of gnosis tests pass by setting xdai rpc to https://xdai-rpc.gateway.pokt.network/ |
@aminlatifi once I change the XDAI node url like you said the error is fixed. If you look at the errors its a UNIQUENESS ERROR. Which doesn't make sense. But I encountered this before. I found the root cause, I think it's a bug in our test library. We should update the test environment to this new url and rerun tests. It's not the PRs issue but some network, xdai rpc url issue. |
when changing Xdai url most tests worked but seems 2 are failing. Couldn't find the cause, if its still the xdai url or something else. |
@CarlosQ96 Let's raise the gnosis provider with the Devops team. |
@aminlatifi I think all test need to pass or else it wont deploy. But I think the code is fine. Its a url/rpc issue not code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we have to fix the URLS/RPC for tests to pass or wont deploy.
Locally all tests pass for me, its an rpc provider issue. |
@geleeroyale @mhmdksh We are having some issue with the gnosis provider as it's not being reliable and failing when requesting data, throwing errors so our tests are failing. |
Hey Carlos! Which provider do we have set? If it is a gateway RPC I recommend to switch back to our quicknode instance |
Changed power_balance_snapshot table balance column to accept null values Change take TAKE_POWER_BOOSTING_SNAPSHOT procedure to make instances of power_balance_snapshot for users has power_boosting_snapshot for each snapshot Updated tests to match these changes
Ref #1067