-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chaintype and solana networks to tokenTab #1827
Conversation
4eda7c0
to
42e5174
Compare
WalkthroughThe changes in the Changes
Possibly related PRs
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (1)
- src/server/adminJs/tabs/tokenTab.ts (3 hunks)
Additional comments not posted (3)
src/server/adminJs/tabs/tokenTab.ts (3)
10-10
: LGTM!The import statement for the
ChainType
enum is syntactically correct and the import path appears to be valid.
214-225
: Looks good!The addition of the Solana network identifiers (
SOLANA_MAINNET
,SOLANA_TESTNET
, andSOLANA_DEVNET
) to thenetworkId
property'savailableValues
array is implemented correctly and aligns with the PR objective of integrating Solana networks into thetokenTab
.
241-248
: Great addition!The introduction of the
chainType
property in thetokenTab
configuration, along with theavailableValues
array providing options for different blockchain types, is a valuable addition that aligns with the PR objective. This change allows for categorization of tokens based on their underlying blockchain technology and enhances the functionality of thetokenTab
.
src/server/adminJs/tabs/tokenTab.ts
Outdated
{ value: ChainType.EVM, label: 'EVM' }, | ||
{ value: ChainType.EVM, label: 'SOLANA' }, | ||
{ value: ChainType.EVM, label: 'STELLAR' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the inconsistency between values and labels.
The availableValues
array for the chainType
property has an inconsistency between the values and labels:
availableValues: [
{ value: ChainType.EVM, label: 'EVM' },
{ value: ChainType.EVM, label: 'SOLANA' },
{ value: ChainType.EVM, label: 'STELLAR' },
],
All three options have the value set to ChainType.EVM
, but the labels suggest that the values should be ChainType.EVM
, ChainType.SOLANA
, and ChainType.STELLAR
respectively.
Apply this diff to fix the inconsistency:
availableValues: [
{ value: ChainType.EVM, label: 'EVM' },
- { value: ChainType.EVM, label: 'SOLANA' },
+ { value: ChainType.SOLANA, label: 'SOLANA' },
- { value: ChainType.EVM, label: 'STELLAR' },
+ { value: ChainType.STELLAR, label: 'STELLAR' },
],
42e5174
to
2674708
Compare
Missing admin Functionality
Summary by CodeRabbit
SOLANA_MAINNET
,SOLANA_TESTNET
, andSOLANA_DEVNET
.chainType
property to categorize tokens by blockchain technology, including options forEVM
,SOLANA
, andSTELLAR
.These enhancements improve user experience by providing more flexibility in selecting networks and classifying tokens.