Skip to content

Commit

Permalink
🐛 Close udp socket after request is done
Browse files Browse the repository at this point in the history
  • Loading branch information
GiyoMoon committed Jan 3, 2022
1 parent 46311b1 commit 97d7f06
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "steam-server-query",
"version": "1.1.0",
"version": "1.1.1",
"description": "Module which implements the Master Server Query Protocol and Game Server Queries.",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down
6 changes: 6 additions & 0 deletions src/gameServer/gameServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ class GameServerQuery {
}
}

this._promiseSocket.closeSocket();

const parsedInfoBuffer = this._parseInfoBuffer(resultBuffer);
return parsedInfoBuffer as InfoResponse;
}
Expand All @@ -105,6 +107,8 @@ class GameServerQuery {
throw new Error(err);
}

this._promiseSocket.closeSocket();

const parsedPlayerBuffer = this._parsePlayerBuffer(resultBuffer);
return parsedPlayerBuffer;
}
Expand All @@ -126,6 +130,8 @@ class GameServerQuery {
throw new Error(err);
}

this._promiseSocket.closeSocket();

const parsedRulesBuffer = this._parseRulesBuffer(resultBuffer);
return parsedRulesBuffer;
}
Expand Down
2 changes: 2 additions & 0 deletions src/masterServer/masterServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ class MasterServerQuery {
}
} while (this._seedId !== ZERO_IP);

this._promiseSocket.closeSocket();

// remove ZERO_IP from end of host list
this._hosts.pop();
return this._hosts;
Expand Down
4 changes: 4 additions & 0 deletions src/promiseSocket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ export class PromiseSocket {
});
}

public closeSocket() {
this._socket.close();
}

private _socketSend(buffer: Buffer, host: string, port: number, timeout: number): Promise<Buffer> {
return new Promise((resolve, reject) => {
this._socket.send(buffer, port, host, (err) => {
Expand Down

0 comments on commit 97d7f06

Please sign in to comment.